Opened 3 years ago
Closed 2 years ago
#29080 closed enhancement (fixed)
Degenerate Metric Submanifold: New features
Reported by: | Dicolevrai | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | geometry | Keywords: | Degenerate Metric Manifold |
Cc: | egourgoulhon | Merged in: | |
Authors: | Hans Fotsing Tetsing | Reviewers: | Eric Gourgoulhon |
Report Upstream: | N/A | Work issues: | |
Branch: | 0b38c0e (Commits, GitHub, GitLab) | Commit: | 0b38c0e06b90dbc2ab404e0ff0c9cbc71b5cc1b1 |
Dependencies: | Stopgaps: |
Description
We add some new methods in the class DegenerateSubmanifold
such as list_of_screens
which returns the list of screens already set on the null submanifold. We also resolve a problem that was not allowed the definition of a second screen distribution.
Change History (7)
comment:1 Changed 3 years ago by
- Commit changed from dde78cbd22ea84dda7f3e985e6d50ff0d8a8f193 to 03cd2966adef8297d7ecb074310c5e873e4019cc
comment:2 Changed 3 years ago by
- Cc egourgoulhon added; eric gourgoulhon removed
- Status changed from new to needs_review
comment:3 Changed 3 years ago by
- Commit changed from 03cd2966adef8297d7ecb074310c5e873e4019cc to 0b38c0e06b90dbc2ab404e0ff0c9cbc71b5cc1b1
comment:4 Changed 3 years ago by
The changes look good to me.
In the above commit, I've only performed some small tweaks. In particular, I've removed the OUTPUT
section in the documentation of the class Screen
(class docstrings shall only have an INPUT
section, which describes the input of the class __init__()
method). Let us wait for the patchbot report...
comment:5 Changed 2 years ago by
- Status changed from needs_review to positive_review
Well, it seems that the patchbot does not want to visit this ticket... Since all tests are passed on my machine and the doc builds successfully, I am setting the ticket to positive review.
comment:6 Changed 2 years ago by
comment:7 Changed 2 years ago by
- Branch changed from public/manifolds/DegenerateMetricAdditionalFeatures to 0b38c0e06b90dbc2ab404e0ff0c9cbc71b5cc1b1
- Resolution set to fixed
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
New features for null submanifolds