Opened 3 years ago

Closed 3 years ago

#29074 closed enhancement (fixed)

Better error message for polar of non-full dimensional polyhedra

Reported by: gh-kliem Owned by:
Priority: minor Milestone: sage-9.1
Component: geometry Keywords: polytopes, polar
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: 47a846e (Commits, GitHub, GitLab) Commit: 47a846e13adfe7872b5ab1299748507f9475bb00
Dependencies: Stopgaps:

Status badges

Description

In #28850 we added an error message when taking the polar of non-polar polytopes.

We also added a keyword in_affine_span, which restricts the polar construction to the affine span of the polytope.

As this is likely the output a user wants, we improve the error message.

We also mark a doctest a long time.

Change History (3)

comment:1 Changed 3 years ago by gh-kliem

  • Branch set to public/29074
  • Commit set to 47a846e13adfe7872b5ab1299748507f9475bb00
  • Status changed from new to needs_review

New commits:

​47a846eimproved error message for polar of non-fulldimensional polytopes

comment:2 Changed 3 years ago by jipilab

  • Status changed from needs_review to positive_review

Looks good to me! The pyflakes is taken care of in #28880.

comment:3 Changed 3 years ago by vbraun

  • Branch changed from public/29074 to 47a846e13adfe7872b5ab1299748507f9475bb00
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.