Opened 3 years ago

Closed 3 years ago

#29067 closed enhancement (fixed)

Make ./configure --help a bit shorter by combining --with-system-SPKG and --with-system-SPK=force

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.1
Component: build: configure Keywords:
Cc: Erik Bray, Dima Pasechnik, John Palmieri Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 1269b08 (Commits, GitHub, GitLab) Commit: 1269b08a5c0f7d9f96c08326e6d0bf3adfbd9dd9
Dependencies: Stopgaps:

Status badges

Description

Also sort the --with-system-SPKG options alphabetically.

Purely cosmetic.

Change History (13)

comment:1 Changed 3 years ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: Erik Bray added
Status: newneeds_review

comment:2 Changed 3 years ago by Matthias Köppe

Branch: u/mkoeppe/make___configure___help_a_bit_shorter_by_combining___with_system_spkg_and___with_system_spk_force

comment:3 Changed 3 years ago by Matthias Köppe

Commit: 5df3c682e00a34ef68f619e6d921c283dd46fd31

It still has some minor difficulties with the alphabet but is better than before.


New commits:

6d7eb15bootstrap: Sort the spkg-configure.m4's alphabetically so that --with-system-SPKG options are sorted
5df3c68m4/sage_spkg_configure.m4: Combine --with-system-SPKG and --with-system-SPK=force in configure --help output

comment:4 Changed 3 years ago by Matthias Köppe

Cc: Dima Pasechnik John Palmieri added

comment:5 Changed 3 years ago by Dima Pasechnik

Could you swap yes and no in {no|yes|force}, as yes is the default value?

comment:6 Changed 3 years ago by Matthias Köppe

Is that the standard? I have sorted them in increasing yes-ness

comment:7 Changed 3 years ago by Dima Pasechnik

maybe

  • m4/sage_spkg_configure.m4

    a b m4_pushdef([SPKG_USE_SYSTEM], [sage_use_system_]SPKG_NAME) 
    5151# BEGIN SAGE_SPKG_CONFIGURE_]m4_toupper($1)[
    5252AC_MSG_NOTICE([=== checking whether to install the $1 SPKG ===])
    5353AC_ARG_WITH([system-]SPKG_NAME,
    54        AS_HELP_STRING(--with-system-SPKG_NAME={no|yes|force},
    55            [detect and use an existing system SPKG_NAME (default: "yes"; "force": exit with an error if no usable version is found)]),
     54       AS_HELP_STRING(--with-system-SPKG_NAME={no|yes (default)|force (exit with an error if no usable version is found)},
     55           [detect and use an existing system SPKG_NAME]),
    5656       [AS_VAR_SET(SPKG_USE_SYSTEM, [$withval])],
    5757       [AS_VAR_SET(SPKG_USE_SYSTEM, [yes])]
    5858)

?

this saves a line per spkg.

comment:8 Changed 3 years ago by Matthias Köppe

Fine with me, please commit

comment:9 Changed 3 years ago by Matthias Köppe

Actually the default is more subtle because a previous choice of "no" persists as the effective default through SAGE_LOCAL.

comment:10 in reply to:  9 Changed 3 years ago by Dima Pasechnik

Branch: u/mkoeppe/make___configure___help_a_bit_shorter_by_combining___with_system_spkg_and___with_system_spk_forcepublic/make___configure___help_a_bit_shorter_by_combining___with_system_spkg_and___with_system_spk_force
Commit: 5df3c682e00a34ef68f619e6d921c283dd46fd311269b08a5c0f7d9f96c08326e6d0bf3adfbd9dd9

New commits:

1269b08save 1 line per spkg

comment:11 Changed 3 years ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

comment:12 Changed 3 years ago by Matthias Köppe

Thank you!

comment:13 Changed 3 years ago by Volker Braun

Branch: public/make___configure___help_a_bit_shorter_by_combining___with_system_spkg_and___with_system_spk_force1269b08a5c0f7d9f96c08326e6d0bf3adfbd9dd9
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.