Opened 2 years ago

Closed 2 years ago

#29063 closed enhancement (fixed)

spkg-configure.m4 for planarity

Reported by: dimpase Owned by:
Priority: major Milestone: sage-9.1
Component: build: configure Keywords:
Cc: fbissey, embray, thansen, infinity0, isuruf, mkoeppe Merged in:
Authors: Dima Pasechnik Reviewers: Isuru Fernando
Report Upstream: N/A Work issues:
Branch: 604dfac (Commits, GitHub, GitLab) Commit: 604dfac2084115b322653dc36b5dc7a2c96eb2f0
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

this is a relatively stable C library, the only problem is that there are also very old versions (2.2.0 on Fedora 26) around, and it's not quite clear whether they work and how to distinguish them.

We do the latter by checking for link member in vertexRec from planarity/graphStructures.h

Change History (5)

comment:1 Changed 2 years ago by dimpase

package names:

planarity libplanarity-dev (Debian)

planarity planarity-devel (Fedora)

comment:2 Changed 2 years ago by dimpase

  • Authors set to Dima Pasechnik

2.2.0 prevents sagelib building, as planarity/graphStructures.h should have

typedef struct
        int  link[2];
        int  index;
        unsigned flags;
} vertexRec;

and not

typedef struct
        int DFSParent, leastAncestor, Lowpoint, adjacentTo;
        int pertinentBicompList, separatedDFSChildList, fwdArcList;
} vertexRec;

So we can write a test using AC_COMPILE_IFELSE().

comment:3 Changed 2 years ago by dimpase

  • Branch set to u/dimpase/packages/planarity-config
  • Cc fbissey embray thansen infinity0 isuruf mkoeppe added
  • Commit set to 604dfac2084115b322653dc36b5dc7a2c96eb2f0
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

604dfacspkg-configure.m4 for planarity

comment:4 Changed 2 years ago by isuruf

  • Reviewers set to Isuru Fernando
  • Status changed from needs_review to positive_review

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/dimpase/packages/planarity-config to 604dfac2084115b322653dc36b5dc7a2c96eb2f0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.