Opened 21 months ago

Last modified 21 months ago

#29057 closed defect

make stack method of Polyhedron use fraction_field — at Version 3

Reported by: gh-LaisRast Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords: polytopes, stack
Cc: jipilab, gh-kliem Merged in:
Authors: Laith Rastanawi Reviewers:
Report Upstream: N/A Work issues:
Branch: public/29057 (Commits, GitHub, GitLab) Commit: add3c827441724ad9d8d05bbd8e98da60fc6ce62
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-LaisRast)

stack method of Polyhedron has the following behavior:

sage: P = polytopes.cross_polytope(4)
sage: P.stack(P.faces(3)[0])
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
...
TypeError: no conversion of this rational to integer

We fix this by extending the base_ring if locus_polyhedron to its fraction_field.

Change History (3)

comment:1 Changed 21 months ago by gh-LaisRast

  • Authors set to Laith Rastanawi
  • Branch set to public/29057
  • Commit set to b7173576997263730cdcc0b918222492a077b1f8
  • Status changed from new to needs_review

New commits:

b717357 make stack method of Polyhedron use fraction_field

comment:2 Changed 21 months ago by git

  • Commit changed from b7173576997263730cdcc0b918222492a077b1f8 to add3c827441724ad9d8d05bbd8e98da60fc6ce62

Branch pushed to git repo; I updated commit sha1. New commits:

adc4ca4fix testing ticket number
add3c82old parent changes to an appropriate base_ring

comment:3 Changed 21 months ago by gh-LaisRast

  • Description modified (diff)
Note: See TracTickets for help on using tickets.