Opened 3 years ago
Closed 3 years ago
#29057 closed defect (fixed)
make stack method of Polyhedron use fraction_field
Reported by: | gh-LaisRast | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | geometry | Keywords: | polytopes, stack |
Cc: | jipilab, gh-kliem | Merged in: | |
Authors: | Laith Rastanawi | Reviewers: | Jonathan Kliem |
Report Upstream: | N/A | Work issues: | |
Branch: | ac7882e (Commits, GitHub, GitLab) | Commit: | ac7882ea3ece571411885cc7582990ec16c1db16 |
Dependencies: | Stopgaps: |
Description (last modified by )
stack
method of Polyhedron
has the following behavior:
sage: P = polytopes.cross_polytope(4) sage: P.stack(P.faces(3)[0]) --------------------------------------------------------------------------- TypeError Traceback (most recent call last) ... TypeError: no conversion of this rational to integer
We fix this by extending the base_ring
of locus_polyhedron
to its fraction_field
.
Change History (8)
comment:1 Changed 3 years ago by
- Branch set to public/29057
- Commit set to b7173576997263730cdcc0b918222492a077b1f8
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
- Commit changed from b7173576997263730cdcc0b918222492a077b1f8 to add3c827441724ad9d8d05bbd8e98da60fc6ce62
comment:3 Changed 3 years ago by
- Description modified (diff)
comment:4 Changed 3 years ago by
- Description modified (diff)
comment:5 Changed 3 years ago by
Looks fine. Maybe you can add backend=self.backend()
for locus polyhedron.
As the inequalities and equations are taken from our original polyhedron, the backend can always handle locus polyhedron.
comment:6 Changed 3 years ago by
- Commit changed from add3c827441724ad9d8d05bbd8e98da60fc6ce62 to ac7882ea3ece571411885cc7582990ec16c1db16
Branch pushed to git repo; I updated commit sha1. New commits:
ac7882e | use self.backend() in locus_polyhedron
|
comment:7 Changed 3 years ago by
- Reviewers set to Jonathan Kliem
- Status changed from needs_review to positive_review
LGTM.
comment:8 Changed 3 years ago by
- Branch changed from public/29057 to ac7882ea3ece571411885cc7582990ec16c1db16
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
make stack method of Polyhedron use fraction_field