Opened 3 years ago
Closed 2 years ago
#29054 closed enhancement (fixed)
polymake: Add system package lists for Perl prereqs
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | packages: experimental | Keywords: | |
Cc: | dimpase, jhpalmieri, jipilab, arojas, isuruf, vdelecroix | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 9de4708 (Commits, GitHub, GitLab) | Commit: | 9de47089141f6eed6a2c5a8725778aec6f924ab4 |
Dependencies: | Stopgaps: |
Description (last modified by )
We add the lists of system packages providing polymake's Perl prerequisites
so that ./configure
will include them in the list of suggested packages.
At least for the distributions that provide these packages, this is more reliable than depending on users reading build/pkgs/polymake/SPKG.txt
.
This is achieved by adding them in distros/
of a new script package perl_cpan_polymake_prereq
(a new dependency of polymake
) with an spkg-configure.m4
that checks for the prerequisites and an spkg-install
that always fails.
(See also the more ambitious #27763, which will not be ready for 9.1.)
Change History (20)
comment:1 Changed 2 years ago by
- Branch set to u/mkoeppe/polymake__make_it_an_error_at_sage___configure_time_if_perl_prerequisites_are_missing
comment:2 Changed 2 years ago by
- Commit set to 12c2b2a793fda45f1df9c4522bd5f8c6ce04fa5a
comment:3 Changed 2 years ago by
Thanks for the feedback. This ticket is not ready for review.
What it is missing (the same applies to the "libnauty" business on #27952) is a way for optional packages to signal configure-time errors ONLY if they are configured to be installed.
This is trickier than it sounds because optional packages may be dependencies of other optional packages. (See also #29363 At the end of configure, indicate which optional/experimental packages are configured to be installed)
comment:4 Changed 2 years ago by
See also - #29498 Do not check for system packages of disabled optional packages
comment:5 Changed 2 years ago by
- Commit changed from 12c2b2a793fda45f1df9c4522bd5f8c6ce04fa5a to e6b8e8092a47e960b7b565bf47f2f7afb05e5e7e
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
b1936c3 | bootstrap: Put SAGE_SPKG_ENABLE(...) before SAGE_SPKG_CONFIGURE_...
|
109b86d | Add script package perl_cpan_polymake_prereq
|
e6b8e80 | build/pkgs/perl_cpan_polymake_prereq: Rename spkg-install to spkg-install.in
|
comment:6 Changed 2 years ago by
+# known correct on Fedora 23
is a blast from the past. The names are still the same on Fedora 30.
comment:7 Changed 2 years ago by
- Summary changed from polymake: Make it an error at sage ./configure time if Perl prerequisites are missing to polymake: Add system package lists for Perl prereqs, warn at sage ./configure time if missing
comment:8 Changed 2 years ago by
- Commit changed from e6b8e8092a47e960b7b565bf47f2f7afb05e5e7e to 41839e98ba24c75e2d3daf6b0d9c45b69cc77900
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
c02e263 | build/pkgs/perl_cpan_polymake_prereq/type: Change to optional
|
0958eb7 | build/pkgs/perl_cpan_polymake_prereq/spkg-configure.m4: Only warn when polymake is going to be installed
|
c19360e | build/pkgs/perl_cpan_polymake_prereq/distros/fedora.txt: Remove outdated comment
|
41839e9 | Add #! to build/pkgs/perl_cpan_polymake_prereq/spkg-install (script package!)
|
comment:9 Changed 2 years ago by
- Commit changed from 41839e98ba24c75e2d3daf6b0d9c45b69cc77900 to d4d832dc4f5fa3eee0d7ddf6ecac9717f1a17a9a
Branch pushed to git repo; I updated commit sha1. New commits:
d4d832d | build/pkgs/perl_cpan_polymake_prereq/spkg-install: Better error message
|
comment:10 Changed 2 years ago by
- Cc arojas isuruf added
- Description modified (diff)
comment:11 Changed 2 years ago by
- Cc vdelecroix added
comment:12 Changed 2 years ago by
- Description modified (diff)
- Summary changed from polymake: Add system package lists for Perl prereqs, warn at sage ./configure time if missing to polymake: Add system package lists for Perl prereqs
comment:13 Changed 2 years ago by
- Commit changed from d4d832dc4f5fa3eee0d7ddf6ecac9717f1a17a9a to 18f135259e8738e23e684529d253a2168435272f
Branch pushed to git repo; I updated commit sha1. New commits:
18f1352 | fixup
|
comment:14 Changed 2 years ago by
- Commit changed from 18f135259e8738e23e684529d253a2168435272f to 9de47089141f6eed6a2c5a8725778aec6f924ab4
comment:15 Changed 2 years ago by
- Status changed from new to needs_review
comment:16 Changed 2 years ago by
without the description on #27763 it's a bit unclear what this is meant to do.
comment:17 Changed 2 years ago by
- Description modified (diff)
comment:18 Changed 2 years ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_review to positive_review
lgtm
comment:19 Changed 2 years ago by
Thanks!
comment:20 Changed 2 years ago by
- Branch changed from u/mkoeppe/polymake__make_it_an_error_at_sage___configure_time_if_perl_prerequisites_are_missing to 9de47089141f6eed6a2c5a8725778aec6f924ab4
- Resolution set to fixed
- Status changed from positive_review to closed
Is this ready for review? Some comments, in any case: when I use this on OS X,
perl_cpan_polymake_prereq
fails to build, and its log file says:A key point is that it doesn't have a line matching the regular expression
^Error
, so I see this:I assume you're going to make
spkg-install
fail with a meaningful error message?New commits:
bootstrap: Put SAGE_SPKG_ENABLE(...) before SAGE_SPKG_CONFIGURE_...
Add script package perl_cpan_polymake_prereq