#29052 closed enhancement (fixed)

Create build/bin/sage-build-env-config and call it from build/make/deps; add sage --buildsh

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.1
Component: build Keywords:
Cc: dimpase, embray, jdemeyer, fbissey, isuruf Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik, Volker Braun
Report Upstream: N/A Work issues:
Branch: 2ab9b09 (Commits, GitHub, GitLab) Commit: 2ab9b09b39a4b5f8e73e88aba24aad78c2ff31d5
Dependencies: #29233 Stopgaps:

Status badges

Description (last modified by mkoeppe)

This is part of #21707 - "Split sage-env into 5".

We set up a new configure-generated, to-be-sourced shell script build/bin/sage-build-env-config to which we move environment variable settings from src/bin/sage-env[-config] that are only needed for:

  1. Sage-the-distribution while building spkgs,
  2. Sage-the-distribution for building sagelib.

The new script is used in addition to src/bin/sage-env in these two contexts.

We add a command sage --buildsh, like sage --sh but using the larger environment.


Follow-up:

  • build/make/install contains more environment settings that should be reviewed for moving to sage-build-env-config

Change History (31)

comment:1 Changed 23 months ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 23 months ago by mkoeppe

  • Description modified (diff)

comment:3 Changed 23 months ago by mkoeppe

  • Summary changed from Create build/bin/sage-build-env and call it from build/make/deps; add sage --buildsh to Create build/bin/sage-build-env-config and call it from build/make/deps; add sage --buildsh

comment:4 Changed 23 months ago by mkoeppe

  • Branch set to u/mkoeppe/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh

comment:5 Changed 23 months ago by git

  • Commit set to e3e5a08b074a5546c2363a256525a1233c929c6a

Branch pushed to git repo; I updated commit sha1. New commits:

e3e5a08build/make/deps, build/make.Makefile.in: Source build/bin/sage-build-env-config for building sagelib and for script packages

comment:6 Changed 23 months ago by mkoeppe

  • Cc dimpase embray jdemeyer fbissey added
  • Status changed from new to needs_review

Updated the branch that was on #21707.

comment:7 Changed 23 months ago by mkoeppe

  • Description modified (diff)

comment:8 Changed 23 months ago by jhpalmieri

You need to document sage --buildsh: at the top of src/bin/sage, in src/doc/en/reference/repl/options.rst, maybe in src/doc/en/installation/source.rst, maybe in the developer's guide.

comment:9 Changed 23 months ago by mkoeppe

Thanks! Will do.

comment:10 Changed 23 months ago by git

  • Commit changed from e3e5a08b074a5546c2363a256525a1233c929c6a to 4a96e269c521e1d52dd7d402c8a17b89f047c8e3

Branch pushed to git repo; I updated commit sha1. New commits:

7ea77bbDocument 'sage -buildsh' in the output of 'sage -advanced'
4a96e26src/doc/en/reference/repl/options.rst: Document sage --buildsh

comment:11 Changed 23 months ago by git

  • Commit changed from 4a96e269c521e1d52dd7d402c8a17b89f047c8e3 to 80c6bfde8e413961bd6e13f20c4571269bc30690

Branch pushed to git repo; I updated commit sha1. New commits:

80c6bfdMerge tag '9.1.beta1' into t/29052/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh

comment:12 Changed 23 months ago by mkoeppe

Merged, ready for review

comment:13 Changed 22 months ago by git

  • Commit changed from 80c6bfde8e413961bd6e13f20c4571269bc30690 to ecb6a8bf9050f079f743b8bb826450a12d5f75d3

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5244060Split out build/bin/sage-build-env-config from sage-env-config
96b6c58src/bin/sage: Add -buildsh
3491a9dbuild/make/deps, build/make.Makefile.in: Source build/bin/sage-build-env-config for building sagelib and for script packages
11f6797Document 'sage -buildsh' in the output of 'sage -advanced'
ecb6a8bsrc/doc/en/reference/repl/options.rst: Document sage --buildsh

comment:14 Changed 22 months ago by mkoeppe

Rebased on 9.1.beta3, needs review

comment:15 Changed 22 months ago by mkoeppe

  • Cc isuruf added

comment:16 Changed 22 months ago by dimpase

some places say -buildsh, some say --build-sh, some say --buildsh

what's the correct one?

comment:17 Changed 22 months ago by git

  • Commit changed from ecb6a8bf9050f079f743b8bb826450a12d5f75d3 to a0c3c5965b51f473a8a16c58ee3431505d05efa8

Branch pushed to git repo; I updated commit sha1. New commits:

a0c3c59Fix "--build-sh" -> "--buildsh" in a comment

comment:18 Changed 22 months ago by mkoeppe

Both -buildsh and --buildsh work.

comment:19 Changed 22 months ago by git

  • Commit changed from a0c3c5965b51f473a8a16c58ee3431505d05efa8 to c1f0e62472de3abb98300503cb588b127d181f42

Branch pushed to git repo; I updated commit sha1. New commits:

c1f0e62Merge tag '9.1.beta4' into t/29052/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh

comment:20 Changed 22 months ago by mkoeppe

Patchbot errors on helmholtz are due to bootstrap prerequisites missing on that host.

Needs review...

comment:21 Changed 22 months ago by git

  • Commit changed from c1f0e62472de3abb98300503cb588b127d181f42 to 8bd4f532a5b42fdcb9f809c570d85b7c61c03910

Branch pushed to git repo; I updated commit sha1. New commits:

0dc97dbClean src/doc/en/installation/*.txt in bootstrap-clean, not misc-clean
8bd4f53Merge branch 't/29233/bootstrap____make_distclean_broken' into t/29052/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh

comment:22 Changed 22 months ago by mkoeppe

  • Dependencies set to #29233

comment:23 Changed 22 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

ok

comment:24 Changed 22 months ago by mkoeppe

Thank you!

comment:25 Changed 22 months ago by vbraun

  • Status changed from positive_review to needs_work
[dochtml] Error building the documentation.
[dochtml] Traceback (most recent call last):
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
[dochtml]     "__main__", mod_spec)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/runpy.py", line 85, in _run_code
[dochtml]     exec(code, run_globals)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__main__.py", line 2, in <module>
[dochtml]     main()
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 1720, in main
[dochtml]     builder()
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 327, in _wrapper
[dochtml]     getattr(get_builder(document), 'inventory')(*args, **kwds)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 552, in _wrapper
[dochtml]     self._build_everything_except_bibliography(lang, format, *args, **kwds)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 538, in _build_everything_except_bibliography
[dochtml]     build_many(build_ref_doc, non_references)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 280, in build_many
[dochtml]     _build_many(target, args, processes=NUM_THREADS)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/utils.py", line 283, in build_many
[dochtml]     raise worker_exc.original_exception
[dochtml] pkgconfig.pkgconfig.PackageNotFoundError: cblas not found not found

comment:26 Changed 22 months ago by dimpase

was it a build from scratch, or an incremental one?

comment:27 Changed 22 months ago by vbraun

Both incremental and after "make distclean"

comment:28 Changed 22 months ago by git

  • Commit changed from 8bd4f532a5b42fdcb9f809c570d85b7c61c03910 to 2ab9b09b39a4b5f8e73e88aba24aad78c2ff31d5

Branch pushed to git repo; I updated commit sha1. New commits:

2ab9b09Move SAGE_PKG_CONFIG_PATH, SAGE_NAUTY_BINS_PREFIX back to src/bin/sage-env-config.in

comment:29 Changed 22 months ago by mkoeppe

  • Status changed from needs_work to needs_review

Thanks for catching this.

comment:30 Changed 22 months ago by dimpase

  • Reviewers changed from Dima Pasechnik to Dima Pasechnik, Volker Braun
  • Status changed from needs_review to positive_review

OK, it works now. The previous iteration somehow built, but didn't work, as it turned out, sorry.

comment:31 Changed 21 months ago by vbraun

  • Branch changed from u/mkoeppe/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh to 2ab9b09b39a4b5f8e73e88aba24aad78c2ff31d5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.