Changes between Initial Version and Version 1 of Ticket #29032


Ignore:
Timestamp:
Jan 17, 2020, 5:16:44 PM (3 years ago)
Author:
embray
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29032 – Description

    initial v1  
    22
    33It isn't yet as "complete" as #27824 as it lacks some of the fixes (e.g. the patches to Pillow) which I didn't need for my tests, but which may still be needed on other platforms (TBD).
     4
     5----
    46
    57The spkg-configure.m4 itself is taken almost directly from #27824, as most of it was great, except for a couple minor changes:
     
    1113* `AC_SUBST([SAGE_SYSTEM_PYTHON])` instead of `AC_SUBST([PYTHON_FOR_VENV])`
    1214
     15----
    1316
    1417The changes to `build/make/deps` are also inspired by #27824 but are simpler in my opinion: Instead of creating a virtualenv nested inside SAGE_LOCAL, SAGE_LOCAL itself is just treated as a virtualenv, and we install the necessary files for the Python interpreter to treat it as such, which keeps things simpler, as SAGE_LOCAL + `source sage-env` already fills the same purpose as a virtualenv.
    1518
     19----
     20
     21The changes to `src/sage/env.py` are reworked just a little bit (in particular, the version in #27824 was buggy on Cygwin, as it would privilege system DLLs over DLLs in SAGE_LOCAL).
     22
    1623This was tested on Ubuntu 18.04, and `make ptestlong` passes from a clean build with the system Python detected.  No guarantees about OSX or other platforms.