Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#29026 closed defect (fixed)

update m4ri(e) to Jan 2020 versions

Reported by: Dima Pasechnik Owned by:
Priority: major Milestone: sage-9.1
Component: packages: standard Keywords:
Cc: Isuru Fernando, Martin Albrecht, François Bissey, John Palmieri, Matthias Köppe, Erik Bray Merged in: Volker Braun
Authors: Dima Pasechnik Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: b2f41e8 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Change History (19)

comment:1 Changed 3 years ago by Dima Pasechnik

Cc: Isuru Fernando Martin Albrecht François Bissey John Palmieri added

comment:2 Changed 3 years ago by Dima Pasechnik

Description: modified (diff)

comment:3 Changed 3 years ago by Dima Pasechnik

Authors: Dima Pasechnik
Branch: u/dimpase/packages/m4ris2020
Commit: c88e57a0af966dadc5810c6df29e0d7246d11129

New commits:

fdd3894bump up versions of m4ri and m4rie
c88e57aremove upstreamed m4ri patch

comment:4 Changed 3 years ago by Dima Pasechnik

Cc: Matthias Köppe Erik Bray added
Status: newneeds_review

comment:5 Changed 3 years ago by Matthias Köppe

Tested on macOS, test suite in src/matrix passes.

comment:6 Changed 3 years ago by Matthias Köppe

Fixes #29005.

comment:7 Changed 3 years ago by John Palmieri

I'm also on OS X. Both packages pass their test suites, and make ptestlong succeeds. Doesn't fix #28944 or #28970, unfortunately, but that is not an obstacle to a positive review here.

comment:8 Changed 3 years ago by Dima Pasechnik

anything more I can do here to facilitate reviewing?

comment:9 Changed 3 years ago by Matthias Köppe

Reviewers: Matthias Koeppe
Status: needs_reviewpositive_review

comment:10 Changed 3 years ago by git

Commit: c88e57a0af966dadc5810c6df29e0d7246d11129b2f41e8f110497fc18b75deb1884c575b81b5db2
Status: positive_reviewneeds_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

b2f41e8fix for m4ri/issues/72/a-possible-bug-in-mzd_submatrix

comment:11 Changed 3 years ago by Dima Pasechnik

thsi should be fixing #28944 and #28970

comment:12 Changed 3 years ago by John Palmieri

Again, on OS X they both pass their test suites and make ptestlong succeeds. Looks good to me. If someone can confirm on another platform or two, then positive review.

comment:13 Changed 3 years ago by Dima Pasechnik

I'd bump up the package version to indicate it's got a patch

comment:14 Changed 3 years ago by Matthias Köppe

How should this be addressed in spkg-configure?

comment:15 Changed 3 years ago by Dima Pasechnik

good question. e.g. we can tolerate buggy versions. or not.

comment:16 Changed 3 years ago by Dima Pasechnik

I've asked upstream to make a new release. With it in place it will be easy to detect a good version.

comment:17 Changed 3 years ago by Volker Braun

Merged in: Volker Braun
Status: needs_reviewpositive_review

Can go to a followup ticket imho...

comment:18 Changed 3 years ago by Volker Braun

Branch: u/dimpase/packages/m4ris2020b2f41e8f110497fc18b75deb1884c575b81b5db2
Resolution: fixed
Status: positive_reviewclosed

comment:19 Changed 3 years ago by Martin Albrecht

Commit: b2f41e8f110497fc18b75deb1884c575b81b5db2
Note: See TracTickets for help on using tickets.