#29026 closed defect (fixed)
update m4ri(e) to Jan 2020 versions
Reported by: | Dima Pasechnik | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | packages: standard | Keywords: | |
Cc: | Isuru Fernando, Martin Albrecht, François Bissey, John Palmieri, Matthias Köppe, Erik Bray | Merged in: | Volker Braun |
Authors: | Dima Pasechnik | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | b2f41e8 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Change History (19)
comment:1 Changed 3 years ago by
Cc: | Isuru Fernando Martin Albrecht François Bissey John Palmieri added |
---|
comment:2 Changed 3 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 3 years ago by
Authors: | → Dima Pasechnik |
---|---|
Branch: | → u/dimpase/packages/m4ris2020 |
Commit: | → c88e57a0af966dadc5810c6df29e0d7246d11129 |
comment:4 Changed 3 years ago by
Cc: | Matthias Köppe Erik Bray added |
---|---|
Status: | new → needs_review |
comment:7 Changed 3 years ago by
comment:9 Changed 3 years ago by
Reviewers: | → Matthias Koeppe |
---|---|
Status: | needs_review → positive_review |
comment:10 Changed 3 years ago by
Commit: | c88e57a0af966dadc5810c6df29e0d7246d11129 → b2f41e8f110497fc18b75deb1884c575b81b5db2 |
---|---|
Status: | positive_review → needs_review |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
b2f41e8 | fix for m4ri/issues/72/a-possible-bug-in-mzd_submatrix
|
comment:12 Changed 3 years ago by
Again, on OS X they both pass their test suites and make ptestlong
succeeds. Looks good to me. If someone can confirm on another platform or two, then positive review.
comment:16 Changed 3 years ago by
I've asked upstream to make a new release. With it in place it will be easy to detect a good version.
comment:17 Changed 3 years ago by
Merged in: | → Volker Braun |
---|---|
Status: | needs_review → positive_review |
Can go to a followup ticket imho...
comment:18 Changed 3 years ago by
Branch: | u/dimpase/packages/m4ris2020 → b2f41e8f110497fc18b75deb1884c575b81b5db2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:19 Changed 3 years ago by
Commit: | b2f41e8f110497fc18b75deb1884c575b81b5db2 |
---|
FWIW I've made new releases:
Note: See
TracTickets for help on using
tickets.
New commits:
bump up versions of m4ri and m4rie
remove upstreamed m4ri patch