Opened 3 years ago

Closed 3 years ago

#29021 closed defect (fixed)

Bug in setting the calculus method on manifolds

Reported by: egourgoulhon Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords: manifolds, calculus
Cc: tscrim Merged in:
Authors: Eric Gourgoulhon Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 02f0418 (Commits, GitHub, GitLab) Commit: 02f0418649826f05be7f704e963c6f275f81eb80
Dependencies: Stopgaps:

Status badges

Description (last modified by egourgoulhon)

In Sage 9.1.beta0, we have 

sage: M = Manifold(2, 'M')
sage: M.set_calculus_method('sympy')
sage: X.<x,y> = M.chart()
sage: X.calculus_method()
Available calculus methods (* = current):
 - SR (default) (*)
 - sympy

while the current calculus method on the chart X should be sympy, as requested for any chart on M by M.set_calculus_method('sympy'). Prior to Sage 8.8, it was OK. The bug was actually introduced in #27601 (merged in Sage 8.8.beta1) by the accidental removal of the line 

self._calculus_method = method

in the code of set_calculus_method().

This ticket fixes it by restoring the missing line.

Change History (7)

comment:1 Changed 3 years ago by egourgoulhon

  • Branch set to public/manifolds/bug_in_set_calculus_method-29021
  • Commit set to f993d721e5724d2c4db3894c532c24d21bf38510

New commits:

​f993d72#29021: fix bug in set_calculus_method

comment:2 Changed 3 years ago by egourgoulhon

  • Description modified (diff)

comment:3 Changed 3 years ago by egourgoulhon

  • Cc tscrim added
  • Status changed from new to needs_review

comment:4 Changed 3 years ago by git

  • Commit changed from f993d721e5724d2c4db3894c532c24d21bf38510 to 02f0418649826f05be7f704e963c6f275f81eb80

Branch pushed to git repo; I updated commit sha1. New commits:

​02f0418#29021: add a doctest

comment:5 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 3 years ago by egourgoulhon

Thank you for the review!

comment:7 Changed 3 years ago by vbraun

  • Branch changed from public/manifolds/bug_in_set_calculus_method-29021 to 02f0418649826f05be7f704e963c6f275f81eb80
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.