Opened 8 months ago
Closed 8 months ago
#29021 closed defect (fixed)
Bug in setting the calculus method on manifolds
Reported by:  egourgoulhon  Owned by:  

Priority:  major  Milestone:  sage9.1 
Component:  geometry  Keywords:  manifolds, calculus 
Cc:  tscrim  Merged in:  
Authors:  Eric Gourgoulhon  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  02f0418 (Commits)  Commit:  02f0418649826f05be7f704e963c6f275f81eb80 
Dependencies:  Stopgaps: 
Description (last modified by )
In Sage 9.1.beta0, we have
sage: M = Manifold(2, 'M') sage: M.set_calculus_method('sympy') sage: X.<x,y> = M.chart() sage: X.calculus_method() Available calculus methods (* = current):  SR (default) (*)  sympy
while the current calculus method on the chart X
should be sympy
, as requested for any chart on M
by M.set_calculus_method('sympy')
.
Prior to Sage 8.8, it was OK. The bug was actually introduced in #27601 (merged in Sage 8.8.beta1) by the accidental removal of the line
self._calculus_method = method
in the code of set_calculus_method()
.
This ticket fixes it by restoring the missing line.
Change History (7)
comment:1 Changed 8 months ago by
 Branch set to public/manifolds/bug_in_set_calculus_method29021
 Commit set to f993d721e5724d2c4db3894c532c24d21bf38510
comment:2 Changed 8 months ago by
 Description modified (diff)
comment:3 Changed 8 months ago by
 Cc tscrim added
 Status changed from new to needs_review
comment:4 Changed 8 months ago by
 Commit changed from f993d721e5724d2c4db3894c532c24d21bf38510 to 02f0418649826f05be7f704e963c6f275f81eb80
Branch pushed to git repo; I updated commit sha1. New commits:
02f0418  #29021: add a doctest

comment:5 Changed 8 months ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
LGTM.
comment:6 Changed 8 months ago by
Thank you for the review!
comment:7 Changed 8 months ago by
 Branch changed from public/manifolds/bug_in_set_calculus_method29021 to 02f0418649826f05be7f704e963c6f275f81eb80
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
#29021: fix bug in set_calculus_method