Opened 3 months ago

Closed 2 months ago

#29016 closed defect (fixed)

spkg-legacy-uninstall for R

Reported by: dimpase Owned by:
Priority: major Milestone: sage-9.1
Component: build Keywords:
Cc: embray Merged in:
Authors: Dima Pasechnik Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: aa3b1db (Commits) Commit: aa3b1db81f29f717fccfa61761281d1a7f254225
Dependencies: Stopgaps:

Description

R does cleaning inside spkg-install - not good for running make r-clean

Change History (7)

comment:1 Changed 3 months ago by dimpase

Erik, is it safe to remove cleaning from spkg-install, or pre-cleaning is not done, so spkg-legacy-uninstall won't be invoked by ./sage -f r ?

I have left spkg-install untouched so far.

Last edited 3 months ago by dimpase (previous) (diff)

comment:2 Changed 3 months ago by dimpase

  • Status changed from new to needs_review

comment:3 follow-up: Changed 3 months ago by embray

Uh, yeah, you should just remove the relevant lines from the spkg-install. If there's an spkg-legacy-uninstall it will be invoked wen you run ./sage -f r.

Version 0, edited 3 months ago by embray (next)

comment:4 Changed 3 months ago by git

  • Commit changed from ae7b61b638e9547761dc209fd8bb8633b11fe314 to aa3b1db81f29f717fccfa61761281d1a7f254225

Branch pushed to git repo; I updated commit sha1. New commits:

aa3b1dbremoved unneeded rm's in spkg-install

comment:5 in reply to: ↑ 3 Changed 3 months ago by dimpase

Replying to embray:

Uh, yeah, you should just remove the relevant lines from the spkg-install. If there's an spkg-legacy-uninstall it will be invoked when you run ./sage -f r.

ok, thanks, fixed.

comment:6 Changed 3 months ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

comment:7 Changed 2 months ago by vbraun

  • Branch changed from u/dimpase/packages/r-uninstall to aa3b1db81f29f717fccfa61761281d1a7f254225
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.