Opened 3 months ago

Closed 2 months ago

#29015 closed defect (fixed)

Fix frobenius power in non-monic cyclic covers

Reported by: alexjbest Owned by:
Priority: major Milestone: sage-9.1
Component: algebraic geometry Keywords: cyclic cover, zeta function
Cc: edgarcosta, vishalarul Merged in:
Authors: Alex J. Best Reviewers: Frédéric Chapoton, Edgar Costa
Report Upstream: N/A Work issues:
Branch: 4bc02e2 (Commits) Commit: 4bc02e27f52a95e9676bb676ae6d481e32f2d815
Dependencies: Stopgaps:

Description (last modified by alexjbest)

As per the text after (2.8) in (Arul, Vishal, Alex J. Best, Edgar Costa, Richard Magner, and Nicholas Triantafillou. “Computing Zeta Functions of Cyclic Covers in Large Characteristic.” The Open Book Series 2, no. 1 (January 28, 2019): 37–53. ​https://doi.org/10.2140/obs.2019.2.37.) the q-power frobenius is what we need to find the action of, before we used the p-th, see the new doctest for a failing example.

Change History (7)

comment:1 Changed 3 months ago by alexjbest

  • Branch set to u/alexjbest/cycliccoverfix
  • Commit set to abc6382aa8cd1d5837ee275f5416d9f4227981c2
  • Status changed from new to needs_review

New commits:

​abc6382fix frobenius power for non-monic cyclic cover

comment:2 Changed 3 months ago by git

  • Commit changed from abc6382aa8cd1d5837ee275f5416d9f4227981c2 to 96f37f4861baaa501d9139809a05b19c2af0688e

Branch pushed to git repo; I updated commit sha1. New commits:

​96f37f4update trac number

comment:3 Changed 3 months ago by alexjbest

  • Description modified (diff)

comment:4 Changed 3 months ago by git

  • Commit changed from 96f37f4861baaa501d9139809a05b19c2af0688e to 4bc02e27f52a95e9676bb676ae6d481e32f2d815

Branch pushed to git repo; I updated commit sha1. New commits:

​4bc02e2docstring fixees

comment:5 Changed 3 months ago by edgarcosta

The changes look good so far, email me whenever patch bot is happy, then I will also be happy.

comment:6 Changed 2 months ago by chapoton

  • Reviewers set to Frédéric Chapoton, Edgar Costa
  • Status changed from needs_review to positive_review

let it be

comment:7 Changed 2 months ago by vbraun

  • Branch changed from u/alexjbest/cycliccoverfix to 4bc02e27f52a95e9676bb676ae6d481e32f2d815
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.