#29005 closed defect (duplicate)

m4rie test/Makefile.am does not respect LDFLAGS

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords: m4ri, m4rie, LDFLAGS
Cc: isuruf, malb, fbissey, jhpalmieri, dimpase, slelievre Merged in:
Authors: Reviewers: Dima Pasechnik
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

This causes a build error in some configurations, in particular when building on conda.

This is caused by overwriting LDFLAGS in test/Makefile.am, which should never be done. The m4ri package has the same defect.

We propose to apply a workaround similar to the one used in conda-forge (https://github.com/conda-forge/m4rie-feedstock/commit/dea9e9a33ccf951c2458ad53f9af3ed860f81fbf) until hopefully this is fixed upstream and a new release is available.

Change History (11)

comment:1 Changed 15 months ago by fbissey

Funny that, I submitted a patch upstream to be able to run tests out of source back in 2015 https://bitbucket.org/malb/m4rie/commits/303cf7adaa8b4c86fe9516871cb8b1886f3948da but it doesn't look like I noticed that particular issue at the time. Now that you point that out, yes there is a problem there.

comment:2 Changed 15 months ago by mkoeppe

  • Description modified (diff)

comment:3 Changed 15 months ago by mkoeppe

  • Authors Matthias Koeppe deleted

comment:5 Changed 15 months ago by mkoeppe

  • Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

Thank you!

comment:6 Changed 15 months ago by malb

comment:7 Changed 15 months ago by slelievre

  • Cc slelievre added
  • Keywords m4ri m4rie LDFLAGS added
  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.

comment:8 Changed 15 months ago by dimpase

  • Status changed from new to needs_review

The update is on #29026 - please review

comment:9 Changed 15 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-duplicate/invalid/wontfix

Fixed by #29026.

comment:10 Changed 15 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

comment:11 Changed 15 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.