Opened 2 years ago

Closed 4 months ago

#28998 closed enhancement (fixed)

Add script-type _spkg_check package that installs tox, mock, pytest etc.

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: vbraun, jdemeyer, fbissey Merged in:
Authors: Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: public/28998-check_dependencies_package (Commits, GitHub, GitLab) Commit: 623cb21b7cd9f90843524ee1f5f15016afe5ffaf
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

Following a suggestion by vbraun in #19680, this ticket adds a _spkg_check package (type=script) that

  • installs the Python packagestox, mock, pytest via pip if SAGE_CHECK=true
  • does nothing otherwise.

The package _spkg_check can be added as a dependency of Python packages that use this standard testing infrastructure, for testing them if SAGE_CHECK=true.

The branch demonstrates this on the package pygments by adding an spkg-check.

If this approach is favored, probably the spkg nose, currently a dependency of cvxopt and networkx, could be removed.

Change History (13)

comment:1 Changed 2 years ago by mkoeppe

  • Branch set to public/28998-check_dependencies_package

comment:2 Changed 2 years ago by mkoeppe

  • Commit set to 623cb21b7cd9f90843524ee1f5f15016afe5ffaf

On this branch, handling of sage -c does not work yet. Contributions welcome.


New commits:

623cb21Use script package 'check_dependencies' to install tox, pytest, etc.

comment:3 Changed 2 years ago by mkoeppe

  • Description modified (diff)

comment:4 Changed 2 years ago by mkoeppe

  • Description modified (diff)
  • Summary changed from Add script-type check_dependencies package that installs tox, mock, pytest etc. to Add script-type _spkg_check package that installs tox, mock, pytest etc.

comment:5 Changed 2 years ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

pushing these forward to 9.2

comment:6 Changed 2 years ago by mkoeppe

A simpler version, just for pytest, is in #29813, used in #29766 for networkx

comment:7 Changed 2 years ago by mkoeppe

tox in #29909

comment:8 Changed 23 months ago by mkoeppe

#30066: build/pkgs/mock: Downgrade from source=normal to pip, conditionalize dependencies

comment:9 Changed 21 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:10 Changed 15 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:11 Changed 10 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-wishlist

comment:12 Changed 4 months ago by mkoeppe

  • Authors Matthias Koeppe deleted
  • Milestone changed from sage-wishlist to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

Outdated, can close

comment:13 Changed 4 months ago by slelievre

  • Resolution set to fixed
  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.