Opened 3 years ago
Closed 11 months ago
#28998 closed enhancement (fixed)
Add script-type _spkg_check package that installs tox, mock, pytest etc.
| Reported by: | Matthias Köppe | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
| Component: | build | Keywords: | |
| Cc: | Volker Braun, Jeroen Demeyer, François Bissey | Merged in: | |
| Authors: | Reviewers: | Matthias Koeppe | |
| Report Upstream: | N/A | Work issues: | |
| Branch: | public/28998-check_dependencies_package (Commits, GitHub, GitLab) | Commit: | 623cb21b7cd9f90843524ee1f5f15016afe5ffaf |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Following a suggestion by vbraun in #19680, this ticket adds a
_spkg_check package (type=script) that
- installs the Python packages
tox,mock,pytestviapipifSAGE_CHECK=true - does nothing otherwise.
The package _spkg_check can be added as a dependency of Python packages that use this standard testing infrastructure, for testing them if SAGE_CHECK=true.
The branch demonstrates this on the package pygments by adding an spkg-check.
If this approach is favored, probably the spkg nose, currently a dependency of cvxopt and networkx, could be removed.
Change History (13)
comment:1 Changed 3 years ago by
| Branch: | → public/28998-check_dependencies_package |
|---|
comment:2 Changed 3 years ago by
| Commit: | → 623cb21b7cd9f90843524ee1f5f15016afe5ffaf |
|---|
comment:3 Changed 3 years ago by
| Description: | modified (diff) |
|---|
comment:4 Changed 3 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | Add script-type check_dependencies package that installs tox, mock, pytest etc. → Add script-type _spkg_check package that installs tox, mock, pytest etc. |
comment:6 Changed 2 years ago by
comment:8 Changed 2 years ago by
#30066: build/pkgs/mock: Downgrade from source=normal to pip, conditionalize dependencies
comment:9 Changed 2 years ago by
| Milestone: | sage-9.2 → sage-9.3 |
|---|
comment:10 Changed 22 months ago by
| Milestone: | sage-9.3 → sage-9.4 |
|---|
Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
comment:11 Changed 17 months ago by
| Milestone: | sage-9.4 → sage-wishlist |
|---|
comment:12 Changed 11 months ago by
| Authors: | Matthias Koeppe |
|---|---|
| Milestone: | sage-wishlist → sage-duplicate/invalid/wontfix |
| Status: | new → needs_review |
Outdated, can close
comment:13 Changed 11 months ago by
| Resolution: | → fixed |
|---|---|
| Reviewers: | → Matthias Koeppe |
| Status: | needs_review → closed |
Note: See
TracTickets for help on using
tickets.
On this branch, handling of
sage -cdoes not work yet. Contributions welcome.New commits:
Use script package 'check_dependencies' to install tox, pytest, etc.