Opened 3 years ago

Closed 3 years ago

#28993 closed defect (fixed)

Adding keyword `prec` to the element constructor of Laurent series

Reported by: Sebastian Oehms Owned by:
Priority: major Milestone: sage-9.1
Component: commutative algebra Keywords: Laurent series, Puiseux series
Cc: Travis Scrimshaw Merged in:
Authors: Sebastian Oehms Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 87cd023 (Commits, GitHub, GitLab) Commit: 87cd023005a814a14e5fb1785bdd5cc6c267dfda
Dependencies: Stopgaps:

Status badges

Description

Currently, we have a keyword prec for power series, but not for Laurent series. A consequence of this is that the function qexp_eta cannot be applied to Laurent series, as observed in this blog post, for example.

sage: L.<q> = LaurentSeriesRing(ZZ)
sage: qexp_eta(L, prec=30)
Traceback (most recent call last):
...
TypeError: _element_constructor_() got an unexpected keyword argument 'prec'

This ticket adds the keyword to Laurent series, as well.

Change History (4)

comment:1 Changed 3 years ago by Sebastian Oehms

Branch: u/soehms/prec_laurent_elem_constr_28993

comment:2 Changed 3 years ago by Sebastian Oehms

Authors: Sebastian Oehms
Commit: 87cd023005a814a14e5fb1785bdd5cc6c267dfda
Status: newneeds_review

I realize the application of that keyword appending a call of the add_bigoh method in order to share the same code for the same functionality.


New commits:

87cd02328993: initial version

comment:3 Changed 3 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

All of the logic for handling the precision is done in the add_bigoh, so this is a good solution IMO.

comment:4 Changed 3 years ago by Volker Braun

Branch: u/soehms/prec_laurent_elem_constr_2899387cd023005a814a14e5fb1785bdd5cc6c267dfda
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.