Opened 21 months ago

Closed 13 months ago

Last modified 12 months ago

#28991 closed enhancement (fixed)

spkg-configure.m4 for gc

Reported by: mjo Owned by:
Priority: major Milestone: sage-9.2
Component: build: configure Keywords:
Cc: embray, dimpase, isuruf Merged in:
Authors: Thierry Thomas, Dima Pasechnik Reviewers: Michael Orlitzky
Report Upstream: N/A Work issues:
Branch: d5c10a5 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

Split off of #28045, where the libatomic dependency is handled.

Attachments (1)

spkg-configure.m4 (210 bytes) - added by gh-thierry-FreeBSD 17 months ago.
spkg-configure.m4 to be copied under build/pkgs/gc

Download all attachments as: .zip

Change History (27)

comment:1 Changed 21 months ago by mjo

  • Dependencies changed from 28045 to #28045

comment:2 Changed 18 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

Changed 17 months ago by gh-thierry-FreeBSD

spkg-configure.m4 to be copied under build/pkgs/gc

comment:3 Changed 17 months ago by gh-thierry-FreeBSD

With the attached spkg-configure.m4, it works for me on FreeBSD, and Sage uses the system package.

Note: ATM the FreeBSD system package is at v.8.0.4 (boehm-gc-threaded-8.0.4_1), and the pkg-config file is named bdw-gc-threaded.pc - this might be different on other systems.

comment:4 follow-up: Changed 17 months ago by mjo

It's bdw-gc.pc on Gentoo at least, so we should check that name too.

comment:5 in reply to: ↑ 4 Changed 17 months ago by dimpase

Replying to mjo:

It's bdw-gc.pc on Gentoo at least, so we should check that name too.

also on Debian and Fedora it is bdw-gc.

  • on Debian on needs to install libgc-dev
  • on Fedora one needs to install gc gc-devel

comment:6 Changed 14 months ago by dimpase

  • Authors set to Thierry Thomas, Dima Pasechnik
  • Branch set to u/dimpase/packages/gc/configm4
  • Commit set to 5a6ce6f8d003b941f173fbcc792d1946d11e0e33
  • Dependencies #28045 deleted
  • Status changed from new to needs_review

New commits:

5a6ce6fspkg-configure for boehm gc

comment:7 Changed 14 months ago by mkoeppe

GH Actions run?

comment:8 Changed 14 months ago by mjo

Works on Gentoo now, thanks!

comment:10 Changed 14 months ago by git

  • Commit changed from 5a6ce6f8d003b941f173fbcc792d1946d11e0e33 to 9e334dd05bb0ff9601d3456da6990f0123ed8a23

Branch pushed to git repo; I updated commit sha1. New commits:

9e334ddmore hints for libatomic_ops on distros

comment:11 Changed 14 months ago by dimpase

  • Cc ​isuruf added

as can be seen on the GH Action logs from https://github.com/dimpase/sage/actions/runs/207790649 libgc is correctly recongnised - if it can be installed

On macOS Conda, libgc is not found: https://github.com/dimpase/sage/runs/982690154

  - https://repo.anaconda.com/pkgs/main/osx-64
  - https://repo.anaconda.com/pkgs/main/noarch
  - https://repo.anaconda.com/pkgs/r/osx-64
  - https://repo.anaconda.com/pkgs/r/noarch

To search for alternate channels that may provide the conda package you're
looking for, navigate to

    https://anaconda.org

and use the search bar at the top of the page.


ERROR: InvocationError for command /bin/bash -c 'PACKAGES=`sed "s/#.*//;" build/pkgs/*/distros/conda.txt`; . /Users/runner/work/sage/sage/.tox/local-conda-forge-macos-standard/conda/bin/activate && /Users/runner/work/sage/sage/.tox/local-conda-forge-macos-standard/conda/bin/conda install --yes --quiet $PACKAGES' (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   local-conda-forge-macos-standard: commands failed
##[error]Process completed with exit code 1.

Isuru, do you get an idea what's wrong here?

comment:12 Changed 14 months ago by dimpase

  • Cc isuruf added; ​isuruf removed

comment:13 Changed 13 months ago by mkoeppe

  • Status changed from needs_review to needs_work

comment:14 Changed 13 months ago by dimpase

I will remove conda.txt

comment:15 Changed 13 months ago by git

  • Commit changed from 9e334dd05bb0ff9601d3456da6990f0123ed8a23 to 6b89b6dee37b5c4c2699f05a2355c8090bd0450a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

eb2ca1dspkg-configure for boehm gc
7d85242more hints for libatomic_ops on distros
6b89b6dleave conda out for the time being

comment:16 Changed 13 months ago by dimpase

  • Status changed from needs_work to needs_review

commented out conda, rebased over 9.2.beta11.

comment:17 follow-up: Changed 13 months ago by mkoeppe

GH run please

comment:18 Changed 13 months ago by git

  • Commit changed from 6b89b6dee37b5c4c2699f05a2355c8090bd0450a to d5c10a5b967108a99c375b1d9c621201e455783c

Branch pushed to git repo; I updated commit sha1. New commits:

d5c10a5also no gc on conda

comment:19 in reply to: ↑ 17 Changed 13 months ago by dimpase

Replying to mkoeppe:

GH run please

see https://github.com/sagemath/sage/pull/98

comment:20 Changed 13 months ago by dimpase

ping?

comment:21 Changed 13 months ago by mjo

  • Reviewers set to Michael Orlitzky
  • Status changed from needs_review to positive_review

LGTM, but can you just delete those conda.txt files rather than comment out their contents? If I'm looking for packages that need Gentoo information, I'm going to be checking for the existence of distros/gentoo.txt and assume that it's correct if present.

comment:22 Changed 13 months ago by dimpase

Thanks!

As to deleting, we already have quite a few of distros/foo.txt with commented out content, e.g. build/pkgs/arb/distros/homebrew.txt, so, no, the content of these files matters matters :-)

comment:23 Changed 13 months ago by vbraun

  • Branch changed from u/dimpase/packages/gc/configm4 to d5c10a5b967108a99c375b1d9c621201e455783c
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:24 follow-up: Changed 12 months ago by mkoeppe

  • Commit d5c10a5b967108a99c375b1d9c621201e455783c deleted

Looks like this may have caused the breakage reported in #30629 (wsl-ubuntu-focal: ECL build fails).

comment:25 in reply to: ↑ 24 Changed 12 months ago by dimpase

Replying to mkoeppe:

Looks like this may have caused the breakage reported in #30629 (wsl-ubuntu-focal: ECL build fails).

it appears that all the released versions of gc suffer from the problem at hand, no?

comment:26 Changed 12 months ago by mkoeppe

If I understand the issue correctly, it's a particular libgc configuration used on Ubuntu 20.04 that is the problem.

Note: See TracTickets for help on using tickets.