#28972 closed enhancement (fixed)

some details about all(...) and return

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-9.1
Component: geometry Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3b38acf (Commits, GitHub, GitLab) Commit: 3b38acf74671b78be0e63a3bf79b492650894015
Dependencies: Stopgaps:

Status badges

Description


Change History (7)

comment:1 Changed 21 months ago by chapoton

  • Branch set to u/chapoton/all_and_return
  • Commit set to 5e1a8725534c39f4f37021b922abe27bb24a9145
  • Status changed from new to needs_review

New commits:

5e1a872fix some details in dynamics and rings (return is not a function)

comment:2 Changed 21 months ago by chapoton

  • Cc tscrim added

bot is morally green, please review

comment:3 Changed 21 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 21 months ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:5 Changed 21 months ago by git

  • Commit changed from 5e1a8725534c39f4f37021b922abe27bb24a9145 to 3b38acf74671b78be0e63a3bf79b492650894015

Branch pushed to git repo; I updated commit sha1. New commits:

3b38acfMerge branch 'u/chapoton/all_and_return' in 9.1.b0

comment:6 Changed 21 months ago by chapoton

  • Status changed from needs_work to positive_review

fixed the trivial conflict, setting back to positive

comment:7 Changed 20 months ago by vbraun

  • Branch changed from u/chapoton/all_and_return to 3b38acf74671b78be0e63a3bf79b492650894015
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.