#28960 closed enhancement (fixed)

Initialize CombinatorialPolyhedron from incidence matrix of cone or lattice polytope

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.1
Component: geometry Keywords: combinatorial polyhedron, cone, lattice polytope
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Laith Rastanawi
Report Upstream: N/A Work issues:
Branch: d513adc (Commits, GitHub, GitLab) Commit: d513adc57450e0f4bb45574019df9ae77cd3eb62
Dependencies: Stopgaps:

Status badges

Description

#28743 and #28766 implemented the incidence matrix for lattice polytopes and cones.

We use the incidence matrix to

  • accept a cone as input of CombinatorialPolyhedron,
  • process a lattice polytope as input more easily.

In both cases the CombinatorialPolyhedron can be obtained without previously calculating the face lattice (avoiding the method facets).

Change History (5)

comment:1 Changed 19 months ago by gh-kliem

  • Branch set to public/28960
  • Commit set to 00a3bf59dcf5ff3bd123d18fad49e5223c893a7a
  • Status changed from new to needs_review

New commits:

00a3bf5initialize combinatorial polyhedron from cone and lattice polytope

comment:2 Changed 17 months ago by gh-kliem

  • Status changed from needs_review to needs_work

Apply failed.

comment:3 Changed 17 months ago by gh-kliem

  • Branch changed from public/28960 to public/28960-reb
  • Commit changed from 00a3bf59dcf5ff3bd123d18fad49e5223c893a7a to d513adc57450e0f4bb45574019df9ae77cd3eb62
  • Status changed from needs_work to needs_review

New commits:

d513adcinitialize combinatorial polyhedron from cone and lattice polytope

comment:4 Changed 16 months ago by gh-LaisRast

  • Reviewers set to Laith Rastanawi
  • Status changed from needs_review to positive_review

It looks good to me!

comment:5 Changed 16 months ago by vbraun

  • Branch changed from public/28960-reb to d513adc57450e0f4bb45574019df9ae77cd3eb62
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.