Opened 2 years ago

Closed 2 years ago

#28956 closed defect (fixed)

correct AC_CHECK_PROG call in spkg-configure for bzip2

Reported by: dimpase Owned by:
Priority: major Milestone: sage-9.1
Component: build: configure Keywords:
Cc: mjo Merged in:
Authors: Dima Pasechnik Reviewers: Erik Bray, Michael Orlitzky
Report Upstream: N/A Work issues:
Branch: 03ded4b (Commits, GitHub, GitLab) Commit: 03ded4b7dfe4eaa5091aee8b10a27519ef3a0cb0
Dependencies: Stopgaps:

Status badges

Description

as noticed in ​https://trac.sagemath.org/ticket/27182#comment:12 it is incorrect, and always fails 

configure:10531: checking for break
configure:10561: result: no

As the fail action is noop, it "works", always.

Change History (10)

comment:1 Changed 2 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/packages/bz2fix

comment:2 Changed 2 years ago by git

  • Commit set to 6b64d6823de85fbc44032c8660cce3373e2f00ef

Branch pushed to git repo; I updated commit sha1. New commits:

​6b64d68correct AC_CHECK/PATH_PROG call, refactor

comment:3 Changed 2 years ago by dimpase

  • Cc mjo added
  • Status changed from new to needs_review

comment:4 Changed 2 years ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

comment:5 Changed 2 years ago by mjo

  • Reviewers changed from Erik Bray to Erik Bray, Michael Orlitzky
  • Status changed from positive_review to needs_work

I still think this is funky. If I rename my /bin/bzip2 program, the test succeeds: 

$ sudo mv /bin/bzip2 /bin/bzip2.bak
$ ./configure
...
configure: === checking whether to install the bzip2 SPKG ===
checking bzlib.h usability... yes
checking bzlib.h presence... yes
checking for bzlib.h... yes
checking for library containing BZ2_bzCompress... -lbz2
checking for bzip2... sage_spkg_install_bzip2=yes
...
    bzip2-1.0.6-20150304.p0 will not be installed (configure check)

The value of the bzip2prog variable is being set to the string sage_spkg_install_bzip2=yes but that snippet is never actually executed.

comment:6 Changed 2 years ago by dimpase

oops. I forgot that the semantic of these macros is different, they don't specify actions.

comment:7 Changed 2 years ago by git

  • Commit changed from 6b64d6823de85fbc44032c8660cce3373e2f00ef to 03ded4b7dfe4eaa5091aee8b10a27519ef3a0cb0

Branch pushed to git repo; I updated commit sha1. New commits:

​03ded4badd forgotten test (arrgh!)

comment:8 Changed 2 years ago by dimpase

  • Status changed from needs_work to needs_review

comment:9 Changed 2 years ago by mjo

  • Status changed from needs_review to positive_review

I think we have a winner.

comment:10 Changed 2 years ago by vbraun

  • Branch changed from u/dimpase/packages/bz2fix to 03ded4b7dfe4eaa5091aee8b10a27519ef3a0cb0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.