#28911 closed enhancement (fixed)

Update sympy to 1.5

Reported by: arojas Owned by:
Priority: major Milestone: sage-9.1
Component: packages: standard Keywords:
Cc: fbissey, gh-timokau, saraedum, slelievre Merged in:
Authors: Antonio Rojas Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: c6d0308 (Commits, GitHub, GitLab) Commit: c6d0308db15efd611211d26cfcbefbd180fc0831
Dependencies: Stopgaps:

Status badges

Description (last modified by arojas)

Removed merged match, updated a few doctest results

Tarball: https://github.com/sympy/sympy/releases/download/sympy-1.5/sympy-1.5.tar.gz

Change History (8)

comment:1 Changed 18 months ago by arojas

  • Branch set to u/arojas/update_sympy_to_1_5

comment:2 Changed 18 months ago by arojas

  • Authors set to Antonio Rojas
  • Cc fbissey gh-timokau saraedum slelievre added
  • Commit set to c6d0308db15efd611211d26cfcbefbd180fc0831
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

New commits:

c6d0308Update sympy to 1.5

comment:3 Changed 18 months ago by fbissey

Finally got rid of that patch? That's awesome news.

I am not familiar with lambert_w but that test in sage/symbolic/relation.py should be checked by someone who knows if it is correct. The other tests are just a matter of factorization.

comment:4 follow-up: Changed 18 months ago by arojas

Both are correct,

lambert_w(±1/2) = ±(1/2)exp(-lambert_w(±1/2))

so

(2·lambert_w(±1/2))^2 = 1/exp(2·lambert_w(±1/2))

comment:5 in reply to: ↑ 4 Changed 18 months ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Replying to arojas:

Both are correct,

lambert_w(±1/2) = ±(1/2)exp(-lambert_w(±1/2))

so

(2·lambert_w(±1/2))^2 = 1/exp(2·lambert_w(±1/2))

Now, I understand, it is just another root of the equation and the order in which they are stored has changed. It all looks good to me.

comment:6 Changed 18 months ago by gh-timokau

Thank you for taking care of this!

comment:7 Changed 18 months ago by chapoton

  • Milestone changed from sage-9.0 to sage-9.1

9.0 is out

comment:8 Changed 18 months ago by vbraun

  • Branch changed from u/arojas/update_sympy_to_1_5 to c6d0308db15efd611211d26cfcbefbd180fc0831
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.