Opened 2 years ago
Closed 2 years ago
#28908 closed enhancement (fixed)
spkg-configure for cbc
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | packages: optional | Keywords: | |
Cc: | dimpase | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 2b07cf5 (Commits, GitHub, GitLab) | Commit: | 2b07cf5ba64c9557c6e6f3f008168886da7e69ad |
Dependencies: | #28175, #27870 | Stopgaps: |
Description (last modified by )
Change History (9)
comment:1 Changed 2 years ago by
- Dependencies set to #28175
- Description modified (diff)
- Milestone changed from sage-9.0 to sage-9.1
comment:2 Changed 2 years ago by
- Branch set to u/mkoeppe/28908_spkg_configure_cbc
comment:3 follow-up: ↓ 4 Changed 2 years ago by
- Commit set to 0e5b5b1d1d557f736baf788f1453b0e83b2b6888
comment:4 in reply to: ↑ 3 Changed 2 years ago by
- Dependencies changed from #28175 to #28175, #27870
Replying to dimpase:
Sage's cbc lists quite a few dependencies (readline zlib bzip2 $(BLAS)) , but none are checked by spkg-configure ... It seems that cbc.pc file is lacking in this sense (along with its dependencies, it seems they don't bother with anything that is external to , they really should list them - should it be reported to upstream?
I'm sure they'd like to know, please go ahead.
Anyhow, we should write these deps out, as it's done in e.g. gsl's ticket #28879
SAGE_SPKG_CONFIGURE([cbc], [ SAGE_SPKG_DEPCHECK([atlas openblas readline zlib bzip2], [ dnl checking with pkg-config PKG_CHECK_MODULES([CBC], [cbc >= 2.9.4], [], [sage_spkg_install_cbc=yes]) ]) ])
Thanks, I'll wait with that until #27870 to be merged.
comment:5 Changed 2 years ago by
I guess their rationale for dependencies in *.pc files is that they don't assume that
blas lapack zlib bzip2
(I scratched readline
out, it's actually not a dependence)
have *.pc files. Which is fair enough.
I've listed this ticket in #27330.
By the way, to move #27870 forward please review its dependence, #28883
comment:6 Changed 2 years ago by
- Commit changed from 0e5b5b1d1d557f736baf788f1453b0e83b2b6888 to 2b07cf5ba64c9557c6e6f3f008168886da7e69ad
comment:7 Changed 2 years ago by
- Status changed from new to needs_review
comment:8 Changed 2 years ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_review to positive_review
looks good to me
comment:9 Changed 2 years ago by
- Branch changed from u/mkoeppe/28908_spkg_configure_cbc to 2b07cf5ba64c9557c6e6f3f008168886da7e69ad
- Resolution set to fixed
- Status changed from positive_review to closed
Sage's cbc lists quite a few dependencies (readline zlib bzip2 $(BLAS)) , but none are checked by spkg-configure, whereas they are really there, as may be seen on Debian by running
It seems that cbc.pc file is lacking in this sense (along with its dependencies, it seems they don't bother with anything that is external to , they really should list them - should it be reported to upstream?
Anyhow, we should write these deps out, as it's done in e.g. gsl's ticket #28879
Perhaps we should update the copy of cbc.pc, to include all these deps (more precisely, all but altlas) in the
Requires:
field.New commits:
Add packages sage_numerical_backends_*
Fixup dependencies
Replace CoinBackend, CPLEXBackend, GurobiBackend by their versions imported from sage_numerical_backends_*
build/pkgs/sage_numerical_backends_*/spkg-install: Adjust error message
src/doc/en/thematic_tutorials/linear_programming.rst: Update COIN/CPLEX/Gurobi install instructions
MixedIntegerLinearProgram: Update docstrings for class and __init__, refer to thematic tutorial, and reduce copy-paste
get_solver: Reduce copy-paste in docstring
src/doc/en/thematic_tutorials/linear_programming.rst: Update license info, URL for cbc
build/pkgs/cbc/spkg-configure.m4: New