Opened 2 years ago

Closed 2 years ago

#28896 closed enhancement (fixed)

Graphs: Move common methods of backends to CGraph

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.0
Component: graph theory Keywords: graphs, backends
Cc: Merged in:
Authors: Jonathan Kliem Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 28c028d (Commits, GitHub, GitLab) Commit: 28c028d378b75e21badc1e8cdafbe7f0be5248ea
Dependencies: Stopgaps:

Status badges

Description

There is a few methods that are implemented exactly the same way in dense and sparse graph:

  • add_arc
  • has_arc
  • del_all_arcs
  • out_neighbors
  • in_neighbors

All they do is wrap the corresponding unsafe methods. So it makes sense to move that code all to CGraph.

Change History (4)

comment:1 Changed 2 years ago by gh-kliem

  • Branch set to public/28896
  • Commit set to 28c028d378b75e21badc1e8cdafbe7f0be5248ea

New commits:

28c028dmove common methods of graph backends to CGraph

comment:2 Changed 2 years ago by gh-kliem

  • Status changed from new to needs_review

comment:3 Changed 2 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 2 years ago by vbraun

  • Branch changed from public/28896 to 28c028d378b75e21badc1e8cdafbe7f0be5248ea
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.