Opened 8 months ago

Closed 7 weeks ago

#28894 closed enhancement (fixed)

Move most important attributes of FaceIterator to a structure.

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: combinatorial polyhedron, face iterator, f-vector
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Jean-Philippe Labbé, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 142d3a8 (Commits) Commit: 142d3a882bbf65e0f38c1fe93cd18a8e0098ab65
Dependencies: Stopgaps:

Description (last modified by gh-kliem)

This ticket is part of a series of tickets to parallelize the f-vector for polyhedra.

Python classes may not be accessed in nogil. To access important attributes of the class FaceIterator, we move those attributes to a structure, which can be accessed in nogil.

Along the way, the ticket simplifies some doctests that define cython functions.

Change History (19)

comment:1 Changed 8 months ago by gh-kliem

  • Branch set to public/28894
  • Commit set to 25825497cbfc8ba20badc8f73cd10c16a42632d5

New commits:

2582549important attributes of iterator in structure

comment:2 Changed 8 months ago by gh-kliem

  • Status changed from new to needs_review

comment:3 Changed 7 months ago by gh-kliem

  • Branch changed from public/28894 to public/28894-reb
  • Commit changed from 25825497cbfc8ba20badc8f73cd10c16a42632d5 to db3139061c8c9062cee382866b5a5dd28fd8b2b2

New commits:

db31390important attributes of iterator in structure

comment:4 Changed 7 months ago by embray

  • Milestone changed from sage-9.0 to sage-9.1

Ticket retargeted after milestone closed

comment:5 Changed 6 months ago by gh-kliem

  • Branch changed from public/28894-reb to public/28894-reb2
  • Commit changed from db3139061c8c9062cee382866b5a5dd28fd8b2b2 to 3e7f7f8de3a288619b3fa20807ca8429622010d9

New commits:

c3e2cb7important attributes of iterator in structure
3e7f7f8applied changes to simplicity and simpliciality

comment:6 Changed 6 months ago by git

  • Commit changed from 3e7f7f8de3a288619b3fa20807ca8429622010d9 to c0c9a314d21a0bbe53f877034eec27c6d7fbf2df

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8d933c3important attributes of iterator in structure
c0c9a31applied changes to simplicity and simpliciality

comment:7 Changed 5 months ago by gh-kliem

  • Status changed from needs_review to needs_work

Apply failed.

comment:8 Changed 5 months ago by gh-kliem

  • Branch changed from public/28894-reb2 to public/28894-reb3
  • Commit changed from c0c9a314d21a0bbe53f877034eec27c6d7fbf2df to 6d0644a68801a0ae6957bb63984103270d02414d
  • Description modified (diff)
  • Status changed from needs_work to needs_review

New commits:

a58ffbeimportant attributes of iterator in structure
6d0644asimplification of doctests

comment:9 Changed 4 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:10 Changed 4 months ago by gh-kliem

  • Branch changed from public/28894-reb3 to public/28894-reb4
  • Commit changed from 6d0644a68801a0ae6957bb63984103270d02414d to 56dcddfb6a4d1210426370309f4f5de707362efe
  • Description modified (diff)

New commits:

41eb697important attributes of iterator in structure
56dcddfsrc/simplification of doctests

comment:11 Changed 3 months ago by gh-kliem

  • Branch changed from public/28894-reb4 to public/28894-reb5
  • Commit changed from 56dcddfb6a4d1210426370309f4f5de707362efe to 53fd2a22dc05f93949b8390a5d24aae12eca1e06

New commits:

0c44221important attributes of iterator in structure
efb0bd3src/simplification of doctests
53fd2a2fixed failing doctest

comment:12 Changed 3 months ago by jipilab

  • Reviewers set to Jean-Philippe Labbé
  • Status changed from needs_review to positive_review

Looks good to me.

comment:13 Changed 3 months ago by gh-kliem

Thank you.

comment:14 Changed 3 months ago by git

  • Commit changed from 53fd2a22dc05f93949b8390a5d24aae12eca1e06 to 142d3a882bbf65e0f38c1fe93cd18a8e0098ab65
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

142d3a8bad alignment causing bug noticed in #28982

comment:15 Changed 3 months ago by gh-kliem

In the dual case the n_atoms/n_coatoms where initialized wrong in the face iterator. This made doctests in #28982 fail.

comment:16 Changed 7 weeks ago by chapoton

  • Reviewers changed from Jean-Philippe Labbé to Jean-Philippe Labbé, Frédéric chapoton
  • Status changed from needs_review to positive_review

back to positive

comment:17 Changed 7 weeks ago by chapoton

  • Reviewers changed from Jean-Philippe Labbé, Frédéric chapoton to Jean-Philippe Labbé, Frédéric Chapoton

comment:18 Changed 7 weeks ago by gh-kliem

Thank you.

comment:19 Changed 7 weeks ago by vbraun

  • Branch changed from public/28894-reb5 to 142d3a882bbf65e0f38c1fe93cd18a8e0098ab65
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.