Opened 3 years ago

Closed 2 years ago

#28892 closed defect (wontfix)

Drop package certifi

Reported by: Michael Orlitzky Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Dima Pasechnik, Joshua Campbell Merged in:
Authors: Reviewers: Michael Orlitzky
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #26919 Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

dependency of tornado:

~/src/sage.git/build/pkgs $ grep -rl 'certifi[^ce]'

However, they are no longer necessary. The file shipped with tornado-4.5.2 indicates this:

if sys.version_info < (2, 7, 9):
if sys.version_info < (3, 4):
    # Certifi is also optional on 2.7.9+, although making our dependencies
    # conditional on micro version numbers seems like a bad idea
    # until we have more declarative metadata.

certifi should be dead weight, except for the fact that the file still mistakenly (with a comment to that effect) requires it. Thus for certifi, I suggest we patch out that one line,

-    install_requires.append('certifi')
+    # install_requires.append('certifi')

Change History (7)

comment:1 Changed 3 years ago by Erik Bray

Milestone: sage-9.0sage-9.1

Ticket retargeted after milestone closed

comment:2 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.1sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:3 Changed 2 years ago by Matthias Köppe

Cc: Dima Pasechnik Joshua Campbell added
Dependencies: #26919
Description: modified (diff)
Summary: Drop packages backports_ssl_match_hostname and certifiDrop package certifi

backports_ssl_match_hostname was removed in #29754, so I have narrowed the ticket to certifi.

tornado is updated in #26919. It should be checked what the situation with certifi is in the new version.

comment:4 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:5 Changed 2 years ago by Matthias Köppe

Milestone: sage-9.2sage-duplicate/invalid/wontfix
Status: newneeds_review

Also matplotlib 3.3.1 (#30358) wants certifi.

comment:6 Changed 2 years ago by Michael Orlitzky

Reviewers: Michael Orlitzky
Status: needs_reviewpositive_review

It looks like we could comment out the dependency in matplotlib, too, but I'm not volunteering to do it so I rescind the suggestion.

comment:7 Changed 2 years ago by Erik Bray

Resolution: wontfix
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.