Opened 3 years ago
Closed 3 years ago
#28880 closed enhancement (fixed)
Prepare setting up polyhedron from both Vrep and Hrep for different backends
Reported by:  ghkliem  Owned by:  

Priority:  major  Milestone:  sage9.1 
Component:  geometry  Keywords:  polytopes, backend, Vrep, Hrep, initialization 
Cc:  JeanPhilippe Labbé, Laith Rastanawi  Merged in:  
Authors:  Jonathan Kliem  Reviewers:  JeanPhilippe Labbé 
Report Upstream:  N/A  Work issues:  
Branch:  561a629 (Commits, GitHub, GitLab)  Commit:  561a6294d385a25f85f61e11e664900d371cb66d 
Dependencies:  Stopgaps: 
Description
#22701 implemented setting up a polyhedron from both Vrep and Hrep for the backend field.
There are plans to allow the same for polymake #26368 and with #28639 at hand we can do the same for normaliz.
So it makes sense to set up a general framework for initializing from Vrep and Hrep. This ticket does this (or rather moves what was done in #22701 accordingly).
If a backend implements the method _init_from_Vrepresentation_and_Hrepresentation
, then the initialization of Polyhedron_base
may use it if Vrep_minimal
and Hrep_minimal
is both set to true.
This option will not be exposed in the function Polyhedron
, as a user should really know what they are doing.
Also the method _element_constructor_polyhedron
of Polyhedra_base
sets up the new polyhedron from both representations, if self.Element
has the method _init_from_Vrepresentation_and_Hrepresentation
.
Change History (6)
comment:1 Changed 3 years ago by
Branch:  → public/28880 

Commit:  → ffcc0bde8c17c3fe5dbb29c913f155deeeaac70c 
Status:  new → needs_review 
comment:2 Changed 3 years ago by
Commit:  ffcc0bde8c17c3fe5dbb29c913f155deeeaac70c → 2c9321ebd9920c159f25c542a372dfd240e84791 

Branch pushed to git repo; I updated commit sha1. New commits:
2c9321e  removed unused import

comment:3 Changed 3 years ago by
Milestone:  sage9.0 → sage9.1 

Ticket retargeted after milestone closed
comment:4 Changed 3 years ago by
Branch:  public/28880 → public/28880reb 

Commit:  2c9321ebd9920c159f25c542a372dfd240e84791 → 561a6294d385a25f85f61e11e664900d371cb66d 
comment:5 Changed 3 years ago by
Reviewers:  → JeanPhilippe Labbé 

Status:  needs_review → positive_review 
Looks good to me! Thanks.
Sorry for the wait...
comment:6 Changed 3 years ago by
Branch:  public/28880reb → 561a6294d385a25f85f61e11e664900d371cb66d 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
prepare setting up from both Vrep and Hrep in general