Opened 3 years ago
Closed 3 years ago
#28876 closed enhancement (fixed)
Polyhedron: Let affine hull fully respect backend
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.0 |
Component: | geometry | Keywords: | polytopes, backend, affine hull |
Cc: | jipilab, gh-LaisRast | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Laith Rastanawi |
Report Upstream: | N/A | Work issues: | |
Branch: | 2cb50f4 (Commits, GitHub, GitLab) | Commit: | 2cb50f47c3eae07de205ed7e4f6b428ea1505e0c |
Dependencies: | Stopgaps: |
Description
The method affine hull does not preserve backend, when orthogonal
or orthonormal
is True
.
We fix this.
normaliz
should be able to handle most base rings that appear with this method, so this is mostly usefull for the backend normaliz
.
Change History (4)
comment:1 Changed 3 years ago by
- Branch set to public/28876
- Commit set to 2cb50f47c3eae07de205ed7e4f6b428ea1505e0c
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
- Reviewers set to Laith Rastanawi
It looks good to me. I will put it on positive review once the patchbots are done.
comment:3 Changed 3 years ago by
- Status changed from needs_review to positive_review
comment:4 Changed 3 years ago by
- Branch changed from public/28876 to 2cb50f47c3eae07de205ed7e4f6b428ea1505e0c
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
affine hull preservers backend if orthogonal or orthonormal