Opened 2 years ago
Closed 2 years ago
#28854 closed defect (fixed)
Documentation Improvements of Characteristic Classes
Reported by:  ghDeRhamSource  Owned by:  

Priority:  major  Milestone:  sage9.1 
Component:  geometry  Keywords:  characteristic classes, vector bundles 
Cc:  egourgoulhon, tscrim  Merged in:  
Authors:  Michael Jung  Reviewers:  Varenyam Bakshi 
Report Upstream:  N/A  Work issues:  
Branch:  a94b358 (Commits, GitHub, GitLab)  Commit:  a94b358e1b1e813f6b50e51354a421094b111bee 
Dependencies:  Stopgaps: 
Description (last modified by )
In order to avoid misunderstandings, the term 'genus' was removed in the documentation. Actually, in terms of topology this expression even seems to be wrong for the additive case!
Change History (21)
comment:1 Changed 2 years ago by
 Branch set to u/ghDeRhamSource/documentation_improvements_of_characteristic_classes
comment:2 Changed 2 years ago by
 Commit set to d557f43e4af7ec1df035fe214deaedd844240c7d
 Component changed from PLEASE CHANGE to geometry
 Description modified (diff)
 Keywords characteristic classes vector bundles added
 Type changed from PLEASE CHANGE to enhancement
comment:3 Changed 2 years ago by
 Cc egrougoulhon added
 Description modified (diff)
 Status changed from new to needs_review
Please give it a positive review as soon as possible. Thanks! :)
comment:4 Changed 2 years ago by
We are at beta9 already. Still, is it likely to have this change in Sage9?
comment:5 Changed 2 years ago by
 Cc tscrim added
comment:6 Changed 2 years ago by
I don't feel qualified enough to be able to answer this as it is not my area of expertise. I might be able to grab a geometer to check it, but I cannot promise that. I can say at least the changes are codewise correct.
Eric, this is essentially a trivial ticket, can you quickly check it?
comment:7 Changed 2 years ago by
The description should be correct now. The names are chosen quite general. Still, I feel not comfortable reviewing my own modifications.
If you could grab a geometer, it would be certainly nice. But I think this is not necessary. I could ask my supervisor next week and modify the documentation at some later point if necessary.
However, the term 'genus' is certainly wrong and it would be nice not having this into the final Sage version.
comment:8 Changed 2 years ago by
 Type changed from enhancement to defect
comment:9 Changed 2 years ago by
 Commit changed from d557f43e4af7ec1df035fe214deaedd844240c7d to 6eca01d95de2e901ef96449827bdd39b96a57368
Branch pushed to git repo; I updated commit sha1. New commits:
6eca01d  Merge branch 'develop' into t/28854/documentation_improvements_of_characteristic_classes

comment:10 Changed 2 years ago by
 Milestone changed from sage9.0 to sage9.1
Ticket retargeted after milestone closed
comment:11 Changed 2 years ago by
 Commit changed from 6eca01d95de2e901ef96449827bdd39b96a57368 to a94b358e1b1e813f6b50e51354a421094b111bee
Branch pushed to git repo; I updated commit sha1. New commits:
a94b358  Trac #28854: Merge branch 'develop' into t/28854/documentation_improvements_of_characteristic_classes

comment:12 Changed 2 years ago by
Would you mind to give it a positive review? Thanks! :)
comment:13 Changed 2 years ago by
Eric, would you be able to do the review?
comment:14 Changed 2 years ago by
 Reviewers set to ghvarenyamBakshi
 Status changed from needs_review to positive_review
the change in documentation looks ok to me. This should be done in the new version of sage.
comment:15 Changed 2 years ago by
 Reviewers changed from ghvarenyamBakshi to Varenyam bakshi
comment:16 followup: ↓ 18 Changed 2 years ago by
 Status changed from positive_review to needs_info
Eric, can you take a look at this quickly to make sure it is okay?
comment:17 Changed 2 years ago by
 Cc egourgoulhon added; egrougoulhon removed
comment:18 in reply to: ↑ 16 Changed 2 years ago by
Replying to tscrim:
Eric, can you take a look at this quickly to make sure it is okay?
Sorry for the delay in replying. I was not aware of this ticket, due to the mispelling of my username in the CC. Besides, when you open such ticket, please add it to the metaticket #18528 to increase its visibility.
Yes, it is okay for me. I am setting the ticket back to positive review.
comment:19 Changed 2 years ago by
 Status changed from needs_info to positive_review
comment:20 Changed 2 years ago by
 Reviewers changed from Varenyam bakshi to Varenyam Bakshi
Thank you.
comment:21 Changed 2 years ago by
 Branch changed from u/ghDeRhamSource/documentation_improvements_of_characteristic_classes to a94b358e1b1e813f6b50e51354a421094b111bee
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Trac #28854: term 'genus' removed in documentation