Opened 3 years ago
Closed 3 years ago
#28854 closed defect (fixed)
Documentation Improvements of Characteristic Classes
| Reported by: | Michael Jung | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-9.1 |
| Component: | geometry | Keywords: | characteristic classes, vector bundles |
| Cc: | egourgoulhon, Travis Scrimshaw | Merged in: | |
| Authors: | Michael Jung | Reviewers: | Varenyam Bakshi |
| Report Upstream: | N/A | Work issues: | |
| Branch: | a94b358 (Commits, GitHub, GitLab) | Commit: | a94b358e1b1e813f6b50e51354a421094b111bee |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
In order to avoid misunderstandings, the term 'genus' was removed in the documentation. Actually, in terms of topology this expression even seems to be wrong for the additive case!
Change History (21)
comment:1 Changed 3 years ago by
| Branch: | → u/gh-DeRhamSource/documentation_improvements_of_characteristic_classes |
|---|
comment:2 Changed 3 years ago by
| Authors: | → Michael Jung |
|---|---|
| Commit: | → d557f43e4af7ec1df035fe214deaedd844240c7d |
| Component: | PLEASE CHANGE → geometry |
| Description: | modified (diff) |
| Keywords: | characteristic classes vector bundles added |
| Type: | PLEASE CHANGE → enhancement |
comment:3 Changed 3 years ago by
| Cc: | egrougoulhon added |
|---|---|
| Description: | modified (diff) |
| Status: | new → needs_review |
Please give it a positive review as soon as possible. Thanks! :)
comment:4 Changed 3 years ago by
We are at beta9 already. Still, is it likely to have this change in Sage9?
comment:5 Changed 3 years ago by
| Cc: | Travis Scrimshaw added |
|---|
comment:6 Changed 3 years ago by
I don't feel qualified enough to be able to answer this as it is not my area of expertise. I might be able to grab a geometer to check it, but I cannot promise that. I can say at least the changes are code-wise correct.
Eric, this is essentially a trivial ticket, can you quickly check it?
comment:7 Changed 3 years ago by
The description should be correct now. The names are chosen quite general. Still, I feel not comfortable reviewing my own modifications.
If you could grab a geometer, it would be certainly nice. But I think this is not necessary. I could ask my supervisor next week and modify the documentation at some later point if necessary.
However, the term 'genus' is certainly wrong and it would be nice not having this into the final Sage version.
comment:8 Changed 3 years ago by
| Type: | enhancement → defect |
|---|
comment:9 Changed 3 years ago by
| Commit: | d557f43e4af7ec1df035fe214deaedd844240c7d → 6eca01d95de2e901ef96449827bdd39b96a57368 |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| 6eca01d | Merge branch 'develop' into t/28854/documentation_improvements_of_characteristic_classes
|
comment:10 Changed 3 years ago by
| Milestone: | sage-9.0 → sage-9.1 |
|---|
Ticket retargeted after milestone closed
comment:11 Changed 3 years ago by
| Commit: | 6eca01d95de2e901ef96449827bdd39b96a57368 → a94b358e1b1e813f6b50e51354a421094b111bee |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| a94b358 | Trac #28854: Merge branch 'develop' into t/28854/documentation_improvements_of_characteristic_classes
|
comment:14 Changed 3 years ago by
| Reviewers: | → gh-varenyamBakshi |
|---|---|
| Status: | needs_review → positive_review |
the change in documentation looks ok to me. This should be done in the new version of sage.
comment:15 Changed 3 years ago by
| Reviewers: | gh-varenyamBakshi → Varenyam bakshi |
|---|
comment:16 follow-up: 18 Changed 3 years ago by
| Status: | positive_review → needs_info |
|---|
Eric, can you take a look at this quickly to make sure it is okay?
comment:17 Changed 3 years ago by
| Cc: | egourgoulhon added; egrougoulhon removed |
|---|
comment:18 Changed 3 years ago by
Replying to tscrim:
Eric, can you take a look at this quickly to make sure it is okay?
Sorry for the delay in replying. I was not aware of this ticket, due to the mispelling of my username in the CC. Besides, when you open such ticket, please add it to the metaticket #18528 to increase its visibility.
Yes, it is okay for me. I am setting the ticket back to positive review.
comment:19 Changed 3 years ago by
| Status: | needs_info → positive_review |
|---|
comment:21 Changed 3 years ago by
| Branch: | u/gh-DeRhamSource/documentation_improvements_of_characteristic_classes → a94b358e1b1e813f6b50e51354a421094b111bee |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
New commits:
Trac #28854: term 'genus' removed in documentation