Opened 3 years ago

Closed 3 years ago

#28851 closed enhancement (fixed)

Polar of integer polytopes does not respect backend

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: polytopes, polar
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 50bbb76 (Commits, GitHub, GitLab) Commit: 50bbb7613eefd758e6f33da503a9aa09f08d7efe
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-kliem)

Currently, polytopes over the integers have there own method for polar, which does not respect the given backend: 

sage: polytopes.cube(backend='normaliz').polar().backend()
'ppl'

We add the backend to the constructor to fix this. Any backend that can handle ZZ can also handle QQ.

Change History (3)

comment:1 Changed 3 years ago by gh-kliem

  • Branch set to public/28851
  • Commit set to 50bbb7613eefd758e6f33da503a9aa09f08d7efe
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​50bbb76polar of polytope over integers respects backend

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 3 years ago by vbraun

  • Branch changed from public/28851 to 50bbb7613eefd758e6f33da503a9aa09f08d7efe
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.