Opened 3 years ago
Closed 3 years ago
#28834 closed defect (fixed)
Doctesting: don't test SageNB files unless SageNB has been installed
Reported by: | jhpalmieri | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | sage-9.0 |
Component: | doctest framework | Keywords: | |
Cc: | Merged in: | ||
Authors: | John Palmieri | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | a579a9a (Commits, GitHub, GitLab) | Commit: | a579a9aefdefdae106ab44f11ac88645f48f330a |
Dependencies: | Stopgaps: |
Description
Since SageNB
is now an optional package, we should detect whether it's present before doctesting its files via make ptestlong
and similar commands.
Change History (5)
comment:1 Changed 3 years ago by
- Branch set to u/jhpalmieri/dont_doctest_sagenb
comment:2 Changed 3 years ago by
- Commit set to a579a9aefdefdae106ab44f11ac88645f48f330a
- Status changed from new to needs_review
comment:3 Changed 3 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
ok, seems a reasonable thing to do
comment:4 Changed 3 years ago by
appears to work in Python2 with and without sagenb installed.
comment:5 Changed 3 years ago by
- Branch changed from u/jhpalmieri/dont_doctest_sagenb to a579a9aefdefdae106ab44f11ac88645f48f330a
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Without these changes, a Python 2 build of Sage fails to run doctests. With these changes, tests pass for me with a plain Python 2 build and also after running
./sage -i sagenb
. Before running./sage -i sagenb
,make ptestlong
says(Same with Python 2 or Python 3)
After running
./sage -i sagenb
, with Python 2:So it appears that the extra files are being correctly detected and doctested.
New commits:
trac 28834: doctesting: detect whether sagenb is installed