[with patch, positive review] notebook -- typing in safari is sluggish!

[boothby]

Typing in the current version of the notebook in Safari is significantly slower than typing on an Apple IIe running Windows Vista. Fix it!

[was]

This patch is impossible to apply. It has this line in it

@@ -790,6 +794,29 @@ function resize_all_cells() {

which is the only mention of the resize_all_cells function. So it depends on some other patch you didn't provide.

[boothby]

Sorry, this depends on #2882

[mabshoff]

I am getting rejects against my merge tree:

mabshoff@sage:/scratch/mabshoff/release-cycle/sage-3.0.alpha4/devel/sage$ patch -p1 --dry-run < trac_2883-resize-flood.patch
patching file sage/server/notebook/cell.py
Hunk #1 FAILED at 646.
1 out of 1 hunk FAILED -- saving rejects to file sage/server/notebook/cell.py.rej
patching file sage/server/notebook/js.py

Please rebase against my merge tree alpah4 in the usual place.

Cheers,

Michael

[mabshoff]

[03:19] <mabshoff> wstein-2901: the reject for #2883 is the following:
[03:20] <mabshoff> it is: onKeyUp    = 'return cell_input_resize(this);'
[03:20] <mabshoff> the patch expects: onKeyUp    = 'return cell_input_resize(%s);' 
[03:20] <mabshoff> And it want to replace it with: onKeyUp    = 'return input_keyup(%s, event);' 
[03:20] <wstein-2901> mabshoff -- it should be this.
[03:20] <wstein-2901> "this"
[03:20] <wstein-2901> Oh, I see.
[03:20] <wstein-2901> hmm.
[03:21] <wstein-2901> It should be: onKeyUp    = 'return input_keyup(%s, event);'
[03:21] <mabshoff> ok.
[03:21] <mabshoff> wstein-2901: merging it like that then

[mabshoff]

Merged in Sage 3.0.alpha4