Opened 3 years ago

Closed 3 years ago

#28825 closed enhancement (fixed)

refresh the file combinat/tuple

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.0
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0a1b6ef (Commits, GitHub, GitLab) Commit: 0a1b6efa453237185abb1ed918ed020a2ce0f94f
Dependencies: Stopgaps:

Status badges

Description

replacing the old CombinatorialClass? by EnumeratedSet?

Change History (6)

comment:1 Changed 3 years ago by chapoton

Branch: u/chapoton/28825
Commit: 304ab1083272fa61098165cdbccc4c4a14371140
Status: newneeds_review

New commits:

304ab10refresh the file combinat/tuple

comment:2 Changed 3 years ago by tscrim

The __classcall_private__ methods do not have doctests.

Also, a while-we-are-at-it thing: I don't see why there should be functions that simply redirect to the class. Can we just combine them together?

comment:3 Changed 3 years ago by git

Commit: 304ab1083272fa61098165cdbccc4c4a143711400a1b6efa453237185abb1ed918ed020a2ce0f94f

Branch pushed to git repo; I updated commit sha1. New commits:

0a1b6eftrac 28825 merge class and function for tuples and unordered tuples

comment:4 Changed 3 years ago by chapoton

thx. Done and green bot again.

comment:5 Changed 3 years ago by tscrim

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Thanks. LGTM.

comment:6 Changed 3 years ago by vbraun

Branch: u/chapoton/288250a1b6efa453237185abb1ed918ed020a2ce0f94f
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.