Opened 3 years ago
Closed 3 years ago
#28825 closed enhancement (fixed)
refresh the file combinat/tuple
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.0 |
Component: | combinatorics | Keywords: | |
Cc: | tscrim | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 0a1b6ef (Commits, GitHub, GitLab) | Commit: | 0a1b6efa453237185abb1ed918ed020a2ce0f94f |
Dependencies: | Stopgaps: |
Description
replacing the old CombinatorialClass? by EnumeratedSet?
Change History (6)
comment:1 Changed 3 years ago by
Branch: | → u/chapoton/28825 |
---|---|
Commit: | → 304ab1083272fa61098165cdbccc4c4a14371140 |
Status: | new → needs_review |
comment:2 Changed 3 years ago by
The __classcall_private__
methods do not have doctests.
Also, a while-we-are-at-it thing: I don't see why there should be functions that simply redirect to the class. Can we just combine them together?
comment:3 Changed 3 years ago by
Commit: | 304ab1083272fa61098165cdbccc4c4a14371140 → 0a1b6efa453237185abb1ed918ed020a2ce0f94f |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
0a1b6ef | trac 28825 merge class and function for tuples and unordered tuples
|
comment:5 Changed 3 years ago by
Reviewers: | → Travis Scrimshaw |
---|---|
Status: | needs_review → positive_review |
Thanks. LGTM.
comment:6 Changed 3 years ago by
Branch: | u/chapoton/28825 → 0a1b6efa453237185abb1ed918ed020a2ce0f94f |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
refresh the file combinat/tuple