Opened 18 months ago

Last modified 3 months ago

#28815 new enhancement

src/setup.py: Replace use of is_package_installed_and_updated by sage_conf or features

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.4
Component: build Keywords: sd111
Cc: jdemeyer, arojas, fbissey, dimpase, embray, gh-timokau, isuruf, jhpalmieri Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #30779 Stopgaps:

Status badges

Description (last modified by mkoeppe)

Currently (after #29701), src/setup.py determines what "distributions" to build using is_package_installed_and_updated, which inspects the installation records found in $SAGE_SPKG_INST = $SAGE_LOCAL/var/lib/sage/installed and also the information in $SAGE_PKGS = $SAGE_ROOT/build/pkgs.

Instead, we make it configurable via sage_conf, falling back to testing features.

(Note that after #30779, src/setup.py is intended to be invoked by the user for user-defined venvs, and is separate from build/pkgs/sagelib/setup.py, which is used by the Sage distribution.)

Alternative approach:

  • #29119 Add an autoconf configure script for sagelib

Change History (11)

comment:1 Changed 18 months ago by mkoeppe

  • Dependencies set to #25828

comment:2 Changed 16 months ago by embray

  • Milestone changed from sage-9.0 to sage-9.1

Ticket retargeted after milestone closed

comment:3 Changed 16 months ago by mkoeppe

  • Cc isuruf added

comment:4 Changed 13 months ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-9.2

comment:5 Changed 12 months ago by mkoeppe

  • Cc jhpalmieri added

comment:6 Changed 12 months ago by mkoeppe

  • Dependencies #25828 deleted
  • Description modified (diff)
  • Summary changed from Don't pass SAGE_PKGS to src/setup.py. Replace OptionalExtension(...., package=....) by condition=Feature.is_present(), to Meta-ticket: Don't pass SAGE_PKGS to src/setup.py. Replace OptionalExtension(...., package=....) by condition=Feature.is_present(),

comment:7 Changed 12 months ago by mkoeppe

  • Description modified (diff)

comment:8 Changed 8 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:9 Changed 6 months ago by mkoeppe

  • Dependencies set to #30779
  • Description modified (diff)
  • Summary changed from Meta-ticket: Don't pass SAGE_PKGS to src/setup.py. Replace OptionalExtension(...., package=....) by condition=Feature.is_present(), to src/setup.py: Replace use of is_package_installed_and_updated by sage_conf or features

comment:10 Changed 5 months ago by mkoeppe

  • Keywords sd111 added

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

comment:11 Changed 3 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

Note: See TracTickets for help on using tickets.