Opened 3 years ago

Closed 3 years ago

#28805 closed defect (fixed)

Remove sagenb from DOC_DEPENDENCIES

Reported by: fbissey Owned by:
Priority: major Milestone: sage-9.0
Component: documentation Keywords:
Cc: jhpalmieri, embray, isuruf, gh-timokau Merged in:
Authors: François Bissey, John Palmieri Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: e234ff5 (Commits, GitHub, GitLab) Commit: e234ff5c34332e6c3c31a0c9b3bf62e73fc504e7
Dependencies: Stopgaps:

Status badges

Description

We took care of removing all the dependencies to sagenb during build, in particular, the build of documentation. We also have switched to python3 by default but sagenb is still installed in python3 builds because of its presence in DOC_DEPENDENCIES. It should be removed.

Change History (14)

comment:1 Changed 3 years ago by fbissey

  • Authors set to François Bissey
  • Branch set to u/fbissey/doc_sagenb_less
  • Commit set to a028f89b818fa5380ad02ab5a9b20cd870d0623c
  • Status changed from new to needs_review

And with this commit sagenb is well and truly optional. Its installation will require manual intervention.


New commits:

a028f89remove sagenb from DOC_DEPENDENCIES

comment:2 Changed 3 years ago by jhpalmieri

I'm seeing doctest failures in tests/cmdline.py because the script sage-rst2txt tries to import sagenb. I guess that test should be tagged # py2. Actually, should many of the py2 tags in that file be changed to optional: sagenb?

Maybe it's better to keep them as py2 so that we can find them and delete them more easily, once we drop support for Python 2.

Last edited 3 years ago by jhpalmieri (previous) (diff)

comment:3 Changed 3 years ago by jhpalmieri

  • Branch changed from u/fbissey/doc_sagenb_less to u/jhpalmieri/doc_sagenb_less

comment:4 Changed 3 years ago by fbissey

  • Commit changed from a028f89b818fa5380ad02ab5a9b20cd870d0623c to e234ff5c34332e6c3c31a0c9b3bf62e73fc504e7

Actually I removed all those from sage-on-gentoo. I was wondering why I was the only one seemingly seeing these failures.


New commits:

e234ff5trac 28805: tag some tests "# py2"

comment:5 Changed 3 years ago by chapoton

  • Cc jhpalmieri embray isuruf added

looks good to me. Any other opinion ?

comment:6 Changed 3 years ago by jhpalmieri

It works for me. I'm happy with the basic setup, so someone should review my commit.

comment:7 Changed 3 years ago by dimpase

does rst2txt need Pyhton2, or sagenb? and if yes, why?

comment:8 Changed 3 years ago by jhpalmieri

The script sage-rst2txt contains the line

from sagenb.notebook.docHTMLProcessor import docutilsHTMLProcessor

and that import is in fact used.

As I said in comment:2, we could tag the relevant tests as # optional - sagenb, but I think we will eventually want to delete tests marked # py2, and then we might forget to deal with tests marked with sagenb instead.

comment:9 follow-up: Changed 3 years ago by dimpase

docutilsHTMLProcessor can be trivially pulled out of sagenb. I don't know whether it's of any use though, but still...

comment:10 Changed 3 years ago by gh-timokau

  • Cc gh-timokau added

comment:11 in reply to: ↑ 9 Changed 3 years ago by jhpalmieri

Replying to dimpase:

docutilsHTMLProcessor can be trivially pulled out of sagenb. I don't know whether it's of any use though, but still...

The purpose of sage-rst2txt is "Translate a rst file into a worksheet txt file." I'm not sure what a "worksheet txt file" is, but I think it's for SageNB. So I don't see the point of separating sage-rst2txt from sagenb.

comment:12 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

OK, fine, I should have read the output of sage --rst2txt, sorry. Thanks.

comment:13 Changed 3 years ago by fbissey

  • Authors changed from François Bissey to François Bissey, John Palmieri

comment:14 Changed 3 years ago by vbraun

  • Branch changed from u/jhpalmieri/doc_sagenb_less to e234ff5c34332e6c3c31a0c9b3bf62e73fc504e7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.