Opened 3 months ago

Closed 3 months ago

#28801 closed defect (fixed)

Fix ThreeJS script paths for Firefox on Windows

Reported by: embray Owned by:
Priority: major Milestone: sage-9.0
Component: porting: Cygwin Keywords: windows threejs plot3d firefox
Cc: slelievre Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 69a593b (Commits) Commit: 69a593b10bd313e5012b670a09a95d3dcb12b6e2
Dependencies: Stopgaps:

Description

This is a follow-up to #25129 which attempted to fix script paths in the ThreeJS template on Windows.

It works in Chrome, however as reported on GitHub it does not work on Firefox for Windows, which is a bit fussier about how file paths are formatted in script tags.

Change History (4)

comment:1 Changed 3 months ago by embray

  • Authors set to Erik Bray
  • Branch set to u/embray/ticket-28801
  • Commit set to 69a593b10bd313e5012b670a09a95d3dcb12b6e2
  • Status changed from new to needs_review

New commits:

69a593bTrac #28801: Support local file URLs in script tags on more browsers in

comment:2 Changed 3 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Let it be so.

comment:3 Changed 3 months ago by embray

Thank you.

comment:4 Changed 3 months ago by vbraun

  • Branch changed from u/embray/ticket-28801 to 69a593b10bd313e5012b670a09a95d3dcb12b6e2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.