Opened 14 years ago

Closed 14 years ago

#2879 closed defect (fixed)

[with patch, with positive review] Bug fix in totallyreal_rel

Reported by: jvoight Owned by: citro
Priority: major Milestone: sage-3.0
Component: number theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

There was an bug in the enumeration of relative totally real fields: if the extension was constant (coming from Q), it was ignored by a resultant calculation. Also, some exceptional cases were unintentionally ignored. The fix is attached.

Attachments (4)

8681.patch (1.9 KB) - added by jvoight 14 years ago.
8682.patch (955 bytes) - added by jvoight 14 years ago.
8683.patch (3.8 KB) - added by jvoight 14 years ago.
trac-2879.patch (5.6 KB) - added by craigcitro 14 years ago.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by jvoight

Changed 14 years ago by jvoight

Changed 14 years ago by jvoight

comment:1 Changed 14 years ago by craigcitro

  • Summary changed from [with patch, needs review] Bug fix in totallyreal_rel to [with patch, with positive review] Bug fix in totallyreal_rel

Patch looks good. I'm attaching a new version of the patch, since I had merge troubles.

Changed 14 years ago by craigcitro

comment:2 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged trac-2879.patch in Sage 3.0.alpha5

Note: See TracTickets for help on using tickets.