#28785 closed enhancement (duplicate)
Make spkg-configure.m4 more verbose
| Reported by: | saraedum | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | sage-duplicate/invalid/wontfix |
| Component: | build: configure | Keywords: | spkg-configure.m4 |
| Cc: | embray | Merged in: | |
| Authors: | Reviewers: | ||
| Report Upstream: | N/A | Work issues: | |
| Branch: | u/saraedum/verbose-configure (Commits, GitHub, GitLab) | Commit: | 4379ec9f4c646c2b430766b5eec0ebdb2f2534a2 |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Some spkg-configure.m4 implement a message at the end that says something like will use the package X from the system. It's confusing to me at least that not all packages report this immediately. (They do in the final listing of packages.)
More importantly, it would be nice if all packages that do implement such a check would be explicit about not having passed that test. For example, in the final listing of packages, it would be nice if we had something similar to:
alib will not be installed (using system package) blib will be installed (no suitable system package) clib # no additional comment, does not have a spkg-configure.m4 yet.
Change History (8)
comment:1 Changed 17 months ago by
- Description modified (diff)
comment:2 Changed 17 months ago by
comment:3 Changed 17 months ago by
- Branch set to u/saraedum/verbose-configure
comment:4 Changed 17 months ago by
- Commit set to 4379ec9f4c646c2b430766b5eec0ebdb2f2534a2
Trying to debug a problem, I got really confused by some of the things in the sage_spkg_configure.m4. So I added some comments that I would have found helpful (and fixed the comment on the top explaining CHECK.)
I also restructured the logic a bit. Now it seems more natural to me and this probably also fixed a bug. This might have introduced a few new problems, I haven't really checked carefully, but it works for me.
I changed the meaning of force when there is no check. It now actually tells Sage not to install that package.
[should have done this on GitLab so I can comment inside my changeset…]
New commits:
| 4379ec9 | Make spkg-configure.m4 more verbose
|
comment:5 follow-up: ↓ 8 Changed 17 months ago by
This is now https://gitlab.com/sagemath/sage/merge_requests/38 and https://trac.sagemath.org/ticket/28788
[sorry, but there is no good way to migrate an existing trac ticket to a GitLab Merge Request.]
comment:6 Changed 17 months ago by
- Milestone changed from sage-9.0 to sage-duplicate/invalid/wontfix
- Status changed from new to needs_review
comment:7 Changed 16 months ago by
- Resolution set to duplicate
- Status changed from needs_review to closed
I find the summary toward the end of the main
config.logto be somewhat helpful, where it says things likeIt would be more helpful if this were not buried inside the log file, and it would be even more helpful if it would say (as you are suggesting)
but also something like
I don't know the best wording to handle all of the various cases: system package found (and do you distinguish in this case among standard, optional, or experimental?), standard package but no system package found, optional, experimental.