Opened 3 years ago

Closed 3 years ago

#28779 closed defect (fixed)

Error in "primes_of_bad_reduction" for DynamicalSystem

Reported by: paulfili Owned by:
Priority: minor Milestone: sage-9.0
Component: dynamics Keywords: sd104
Cc: gh-yuankmath, bhutz, atowsley Merged in:
Authors: Paul Fili Reviewers: Adam Towsley
Report Upstream: N/A Work issues:
Branch: 0c4e9b2 (Commits, GitHub, GitLab) Commit: 0c4e9b260f5cb014d66ce68bc4c0506f4004fa57
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description (last modified by atowsley)

Currently "primes_of_bad_reduction" calls, when the base field is not QQ, the function normalize_coordinates. But normalize_coordinates returns an error if the base ring does not have a GCD:

R.<X> = PolynomialRing(ZZ)
K.<b> = NumberField(X^3 - 11)
P.<x,y> = ProjectiveSpace(K, 1)
a = 7/(b-1)
f = DynamicalSystem_projective([a*y^2 - (a*y-x)^2, y^2])
f.primes_of_bad_reduction() # returns an error
# because it calls the following, which
f.normalize_coordinates() # returns an error (and is meant to!)

Change History (9)

comment:1 Changed 3 years ago by atowsley

Cc: atowsley added; adamtowsley removed

comment:2 Changed 3 years ago by atowsley

Description: modified (diff)

comment:3 Changed 3 years ago by paulfili

Branch: u/paulfili/normalize

comment:4 Changed 3 years ago by paulfili

Commit: 0c4e9b260f5cb014d66ce68bc4c0506f4004fa57
Status: newneeds_review

I believe this fixes the issues and preserves the desired functionality.


New commits:

0c4e9b2Fixed error, clears LCM of denominators always, GCD as appropriate

comment:5 Changed 3 years ago by atowsley

Authors: paulfili
Reviewers: Adam Towsley
Status: needs_reviewpositive_review

All of my examples worked properly and it passed all the tests.

comment:6 Changed 3 years ago by chapoton

The author name must be your full real name.

comment:7 Changed 3 years ago by paulfili

Authors: paulfiliPaul Fili, Holly Krieger

Fixed, sorry about that.

comment:8 Changed 3 years ago by paulfili

Authors: Paul Fili, Holly KriegerPaul Fili

Err, autocomplete...

comment:9 Changed 3 years ago by vbraun

Branch: u/paulfili/normalize0c4e9b260f5cb014d66ce68bc4c0506f4004fa57
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.