Error in "primes_of_bad_reduction" for DynamicalSystem
Currently "primes_of_bad_reduction" calls, when the base field is not QQ, the function normalize_coordinates. But normalize_coordinates returns an error if the base ring does not have a GCD:
R.<X> = PolynomialRing(ZZ)
K.<b> = NumberField(X^3  11)
P.<x,y> = ProjectiveSpace(K, 1)
a = 7/(b1)
f = DynamicalSystem_projective([a*y^2  (a*yx)^2, y^2])
f.primes_of_bad_reduction() # returns an error
# because it calls the following, which
f.normalize_coordinates() # returns an error (and is meant to!)
Change History (9)
Cc: 
atowsley added; adamtowsley removed

Description: 
modified (diff)

Branch: 
→ u/paulfili/normalize

Commit: 
→ 0c4e9b260f5cb014d66ce68bc4c0506f4004fa57

Status: 
new →
needs_review

Authors: 
→ paulfili

Reviewers: 
→ Adam Towsley

Status: 
needs_review →
positive_review

Authors: 
paulfili →
Paul Fili, Holly Krieger

Authors: 
Paul Fili, Holly Krieger →
Paul Fili

Branch: 
u/paulfili/normalize →
0c4e9b260f5cb014d66ce68bc4c0506f4004fa57

Resolution: 
→ fixed

Status: 
positive_review →
closed

I believe this fixes the issues and preserves the desired functionality.
New commits:
Fixed error, clears LCM of denominators always, GCD as appropriate