Opened 3 years ago
Closed 3 years ago
#28772 closed enhancement (fixed)
Kneading sequences for the doubling map
Reported by:  John R. Doyle  Owned by:  

Priority:  minor  Milestone:  sage9.1 
Component:  dynamics  Keywords:  sd104, mandelbrot 
Cc:  Merged in:  
Authors:  John Doyle  Reviewers:  John Michael Clark 
Report Upstream:  N/A  Work issues:  
Branch:  3a03181 (Commits, GitHub, GitLab)  Commit:  3a03181865e7aceca6578632bf28f2fc7e69cf4d 
Dependencies:  #28557  Stopgaps: 
Description
Given an angle theta in RR/ZZ, the kneading sequence of theta is a binary string that gives information about the dynamics of theta under the doubling map. These combinatorial kneading sequences are useful for understanding dynamics near the roots of hyperbolic components of the Mandelbrot set.
Change History (18)
comment:1 Changed 3 years ago by
Branch:  → u/jdoyle/kneading_sequences 

comment:2 Changed 3 years ago by
Branch:  u/jdoyle/kneading_sequences → u/jdoyle/kneading_sequence_new 

Commit:  → 99ed665589229eb03b3da5dcd24c641697ad50d3 
comment:3 Changed 3 years ago by
Status:  new → needs_review 

comment:4 Changed 3 years ago by
Reviewers:  → John Michael Clark 

Status:  needs_review → positive_review 
All tests passed.
comment:6 Changed 3 years ago by
LGTM. I resolved the merge conflict and made a few minor edits. This is not my ticket, but it has been sitting for a month and I am working on other functions in the same file (see #28923), so I would like to see this closed.
comment:7 Changed 3 years ago by
Branch:  u/jdoyle/kneading_sequence_new → public/28772 

comment:8 Changed 3 years ago by
Commit:  99ed665589229eb03b3da5dcd24c641697ad50d3 → 3197d5dbb60a7e9561a5bbeb5e43114ee4029aaf 

Status:  needs_work → needs_review 
comment:10 Changed 3 years ago by
Milestone:  sage9.0 → sage9.1 

comment:11 Changed 3 years ago by
Commit:  3197d5dbb60a7e9561a5bbeb5e43114ee4029aaf → 9f9d6aec105e05c40ab26050e7f35bc4ba4baf63 

Status:  positive_review → needs_review 
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
9f9d6ae  fixed pyflakes error

comment:12 Changed 3 years ago by
Fixed an error that was reported by pyflakes. (DynamicalSystem
was imported twice.) Please review again.
comment:13 Changed 3 years ago by
Status:  needs_review → needs_work 

There is a (minor) merge conflict with #28557. I resolved the conflict and will upload the PR after I have tested it.
comment:14 Changed 3 years ago by
Commit:  9f9d6aec105e05c40ab26050e7f35bc4ba4baf63 → 3a03181865e7aceca6578632bf28f2fc7e69cf4d 

Branch pushed to git repo; I updated commit sha1. New commits:
9310d79  28557: fixed the radius in julia_plot

9adac17  28557: fix R_c in documentation and remove whitespace

b098431  Merge tag '9.0.beta9' into 28557

a5a0408  fix pyflakes failures

4da66a2  merge ticket 28557 into 9.0

3a03181  merged ticket 28772 into 28557

comment:15 Changed 3 years ago by
Status:  needs_work → needs_review 

comment:16 Changed 3 years ago by
Status:  needs_review → positive_review 

Looks good on my end. All tests passed.
comment:17 Changed 3 years ago by
Dependencies:  → #28557 

comment:18 Changed 3 years ago by
Branch:  public/28772 → 3a03181865e7aceca6578632bf28f2fc7e69cf4d 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
Cleaned up the branch