Opened 7 months ago

Closed 6 months ago

#28769 closed defect (fixed)

Scalar field raise AttributeError on show_identifiers call

Reported by: gh-LBrunswic Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: Manifold, save_
Cc: egourgoulhon Merged in:
Authors: Eric Gourgoulhon Reviewers: Léo Brunswic
Report Upstream: N/A Work issues:
Branch: a1bee7a (Commits) Commit: a1bee7a0e89378dc8769e57e966b26681235c830
Dependencies: Stopgaps:

Description

The following snippet raises AttributeError

M = Manifold(1, 'M')
C.<x> = M.chart()
phi = M.scalar_field(0)
show_identifiers()

This prevents saving any sage session containing a scalar field object.

Change History (6)

comment:1 Changed 7 months ago by egourgoulhon

  • Authors changed from Léo Brunswic to Eric Gourgoulhon
  • Branch set to public/manifolds/scalarfield__eq__-28769
  • Commit set to a1bee7a0e89378dc8769e57e966b26681235c830

New commits:

a1bee7aMake ScalarField.__eq__() more robust

comment:2 Changed 7 months ago by egourgoulhon

  • Status changed from new to needs_review

The issue was due to an exception not catched in ScalarField.__eq__(). This is fixed in the above commit.

comment:3 Changed 7 months ago by gh-LBrunswic

  • Status changed from needs_review to positive_review

comment:4 Changed 6 months ago by egourgoulhon

Thanks for reporting the bug and for the review!

comment:5 Changed 6 months ago by egourgoulhon

  • Reviewers set to Léo Brunswic

comment:6 Changed 6 months ago by vbraun

  • Branch changed from public/manifolds/scalarfield__eq__-28769 to a1bee7a0e89378dc8769e57e966b26681235c830
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.