Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#28753 closed enhancement (fixed)

Ramification Type for Rational Maps

Reported by: Andrew O'Desky Owned by:
Priority: minor Milestone: sage-9.1
Component: dynamics Keywords: rational functions, ramification, sd104
Cc: Ben Hutz, Travis Scrimshaw Merged in:
Authors: Andrew O'Desky Reviewers: John Doyle, Frédéric Chapoton, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f00e3e8 (Commits, GitHub, GitLab) Commit: f00e3e8bc2f539ff6f0a7f754ec58dc1d49fa21d
Dependencies: Stopgaps:

Status badges

Description (last modified by Andrew O'Desky)

Implement a method which returns the ramification type of a rational function. The ramification type is a list of lists of integers >1 defined by the pseudo code

def ram_type(self):

ram_types=list() for b in self.branch_points():

ram_inds=list() for c in F.preimage(b)

ram_inds.append(e_self(c)) if e_self(c) >1

ram_types.append(ram_inds)

return ram_types

Change History (24)

comment:1 Changed 3 years ago by Andrew O'Desky

Authors: Andrew O'Desky
Component: PLEASE CHANGEdynamics
Description: modified (diff)
Keywords: rational functions ramification added
Priority: majorminor
Type: PLEASE CHANGEenhancement

comment:2 Changed 3 years ago by Andrew O'Desky

Keywords: sd104 added

comment:3 Changed 3 years ago by Andrew O'Desky

Description: modified (diff)

comment:4 Changed 3 years ago by Andrew O'Desky

Description: modified (diff)

comment:5 Changed 3 years ago by Andrew O'Desky

Description: modified (diff)

comment:6 Changed 3 years ago by Andrew O'Desky

Branch: u/gh-aodesky/ramification_type_for_rational_maps

comment:7 Changed 3 years ago by Andrew O'Desky

Commit: feac5a36db96c5617d1e00f3f3e688a3524ea305
Status: newneeds_review

New commits:

feac5a3Added ramification_type().

comment:8 Changed 3 years ago by git

Commit: feac5a36db96c5617d1e00f3f3e688a3524ea305ed31de85ee5bd19183cc24efe8f3fdccce8b529c

Branch pushed to git repo; I updated commit sha1. New commits:

ed31de8Changed factor to be called on the function and a typo in the doctests.

comment:9 Changed 3 years ago by git

Commit: ed31de85ee5bd19183cc24efe8f3fdccce8b529cb9b20293df80d84c5f6846abb56d3ff33b3e8094

Branch pushed to git repo; I updated commit sha1. New commits:

b9b2029Updated doc to include an example with the embedding specified for splitting the Galois orbits of critical points.

comment:10 Changed 3 years ago by git

Commit: b9b20293df80d84c5f6846abb56d3ff33b3e8094f7ec2022ebe5a1978f7c185440fd5cbcda6a4de0

Branch pushed to git repo; I updated commit sha1. New commits:

f7ec202Made the ramification type compute over a sufficiently large field by definition.

comment:11 Changed 3 years ago by John R. Doyle

Status: needs_reviewpositive_review

comment:12 Changed 3 years ago by Frédéric Chapoton

reviewer name missing

comment:13 Changed 3 years ago by John R. Doyle

Reviewers: John Doyle

comment:14 Changed 3 years ago by Volker Braun

Status: positive_reviewneeds_work

Merge conflict, please fix

comment:15 Changed 3 years ago by git

Commit: f7ec2022ebe5a1978f7c185440fd5cbcda6a4de05dde8f0e7e42a59546d6115ad62178df59bafefc

Branch pushed to git repo; I updated commit sha1. New commits:

5dde8f0Merge branch 'u/gh-aodesky/ramification_type_for_rational_maps' of git://trac.sagemath.org/sage into 28753

comment:16 Changed 3 years ago by git

Commit: 5dde8f0e7e42a59546d6115ad62178df59bafefcddb7200ea8fc32b6d8ba24cba7fba2d2f06093cf

Branch pushed to git repo; I updated commit sha1. New commits:

0160c01Merge commit '296b749a019a0365169fe82b5e0859502af909b3' of git://trac.sagemath.org/sage into 28753
fa92c61Merge commit '485ed39a9482fb8336f58c778f2f6a0f847b7caa' of git://trac.sagemath.org/sage into 28753
ddb7200Merge commit 'e5b1ca33870046f4ed9bc5a3a4561fec54b54b3b' of git://trac.sagemath.org/sage into 28753

comment:17 Changed 3 years ago by git

Commit: ddb7200ea8fc32b6d8ba24cba7fba2d2f06093cf0a97a35590c15beaf23c355c70c3fbce13ceef9a

Branch pushed to git repo; I updated commit sha1. New commits:

0a97a35Merge branch 'develop' of git://trac.sagemath.org/sage into 28753

comment:18 Changed 3 years ago by Andrew O'Desky

Status: needs_workneeds_review

comment:19 Changed 3 years ago by Erik Bray

Milestone: sage-9.0sage-9.1

Ticket retargeted after milestone closed

comment:20 Changed 3 years ago by Matthias Köppe

Milestone: sage-9.1sage-9.2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

comment:21 Changed 3 years ago by Frédéric Chapoton

Branch: u/gh-aodesky/ramification_type_for_rational_mapspublic/28753
Cc: Ben Hutz Travis Scrimshaw added
Commit: 0a97a35590c15beaf23c355c70c3fbce13ceef9af00e3e8bc2f539ff6f0a7f754ec58dc1d49fa21d

I have fixed up some details. Now somebody else should switch this back to positive review.


New commits:

daab1f2Merge branch 'u/gh-aodesky/ramification_type_for_rational_maps' of ssh://trac.sagemath.org:22/sage into ram_type
f00e3e8fixing up details

comment:22 Changed 3 years ago by Travis Scrimshaw

Reviewers: John DoyleJohn Doyle, Frédéric Chapoton, Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:23 Changed 3 years ago by Volker Braun

Branch: public/28753f00e3e8bc2f539ff6f0a7f754ec58dc1d49fa21d
Resolution: fixed
Status: positive_reviewclosed

comment:24 Changed 3 years ago by Matthias Köppe

Milestone: sage-9.2sage-9.1
Note: See TracTickets for help on using tickets.