#28753 closed enhancement (fixed)
Ramification Type for Rational Maps
Reported by:  Andrew O'Desky  Owned by:  

Priority:  minor  Milestone:  sage9.1 
Component:  dynamics  Keywords:  rational functions, ramification, sd104 
Cc:  Ben Hutz, Travis Scrimshaw  Merged in:  
Authors:  Andrew O'Desky  Reviewers:  John Doyle, Frédéric Chapoton, Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  f00e3e8 (Commits, GitHub, GitLab)  Commit:  f00e3e8bc2f539ff6f0a7f754ec58dc1d49fa21d 
Dependencies:  Stopgaps: 
Description (last modified by )
Implement a method which returns the ramification type of a rational function. The ramification type is a list of lists of integers >1 defined by the pseudo code
def ram_type(self):
ram_types=list() for b in self.branch_points():
ram_inds=list() for c in F.preimage(b)
ram_inds.append(e_self(c)) if e_self(c) >1
ram_types.append(ram_inds)
return ram_types
Change History (24)
comment:1 Changed 3 years ago by
Authors:  → Andrew O'Desky 

Component:  PLEASE CHANGE → dynamics 
Description:  modified (diff) 
Keywords:  rational functions ramification added 
Priority:  major → minor 
Type:  PLEASE CHANGE → enhancement 
comment:2 Changed 3 years ago by
Keywords:  sd104 added 

comment:3 Changed 3 years ago by
Description:  modified (diff) 

comment:4 Changed 3 years ago by
Description:  modified (diff) 

comment:5 Changed 3 years ago by
Description:  modified (diff) 

comment:6 Changed 3 years ago by
Branch:  → u/ghaodesky/ramification_type_for_rational_maps 

comment:7 Changed 3 years ago by
Commit:  → feac5a36db96c5617d1e00f3f3e688a3524ea305 

Status:  new → needs_review 
comment:8 Changed 3 years ago by
Commit:  feac5a36db96c5617d1e00f3f3e688a3524ea305 → ed31de85ee5bd19183cc24efe8f3fdccce8b529c 

Branch pushed to git repo; I updated commit sha1. New commits:
ed31de8  Changed factor to be called on the function and a typo in the doctests.

comment:9 Changed 3 years ago by
Commit:  ed31de85ee5bd19183cc24efe8f3fdccce8b529c → b9b20293df80d84c5f6846abb56d3ff33b3e8094 

Branch pushed to git repo; I updated commit sha1. New commits:
b9b2029  Updated doc to include an example with the embedding specified for splitting the Galois orbits of critical points.

comment:10 Changed 3 years ago by
Commit:  b9b20293df80d84c5f6846abb56d3ff33b3e8094 → f7ec2022ebe5a1978f7c185440fd5cbcda6a4de0 

Branch pushed to git repo; I updated commit sha1. New commits:
f7ec202  Made the ramification type compute over a sufficiently large field by definition.

comment:11 Changed 3 years ago by
Status:  needs_review → positive_review 

comment:13 Changed 3 years ago by
Reviewers:  → John Doyle 

comment:15 Changed 3 years ago by
Commit:  f7ec2022ebe5a1978f7c185440fd5cbcda6a4de0 → 5dde8f0e7e42a59546d6115ad62178df59bafefc 

Branch pushed to git repo; I updated commit sha1. New commits:
5dde8f0  Merge branch 'u/ghaodesky/ramification_type_for_rational_maps' of git://trac.sagemath.org/sage into 28753

comment:16 Changed 3 years ago by
Commit:  5dde8f0e7e42a59546d6115ad62178df59bafefc → ddb7200ea8fc32b6d8ba24cba7fba2d2f06093cf 

Branch pushed to git repo; I updated commit sha1. New commits:
0160c01  Merge commit '296b749a019a0365169fe82b5e0859502af909b3' of git://trac.sagemath.org/sage into 28753

fa92c61  Merge commit '485ed39a9482fb8336f58c778f2f6a0f847b7caa' of git://trac.sagemath.org/sage into 28753

ddb7200  Merge commit 'e5b1ca33870046f4ed9bc5a3a4561fec54b54b3b' of git://trac.sagemath.org/sage into 28753

comment:17 Changed 3 years ago by
Commit:  ddb7200ea8fc32b6d8ba24cba7fba2d2f06093cf → 0a97a35590c15beaf23c355c70c3fbce13ceef9a 

Branch pushed to git repo; I updated commit sha1. New commits:
0a97a35  Merge branch 'develop' of git://trac.sagemath.org/sage into 28753

comment:18 Changed 3 years ago by
Status:  needs_work → needs_review 

comment:19 Changed 3 years ago by
Milestone:  sage9.0 → sage9.1 

Ticket retargeted after milestone closed
comment:20 Changed 3 years ago by
Milestone:  sage9.1 → sage9.2 

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.
comment:21 Changed 3 years ago by
Branch:  u/ghaodesky/ramification_type_for_rational_maps → public/28753 

Cc:  Ben Hutz Travis Scrimshaw added 
Commit:  0a97a35590c15beaf23c355c70c3fbce13ceef9a → f00e3e8bc2f539ff6f0a7f754ec58dc1d49fa21d 
comment:22 Changed 3 years ago by
Reviewers:  John Doyle → John Doyle, Frédéric Chapoton, Travis Scrimshaw 

Status:  needs_review → positive_review 
LGTM.
comment:23 Changed 3 years ago by
Branch:  public/28753 → f00e3e8bc2f539ff6f0a7f754ec58dc1d49fa21d 

Resolution:  → fixed 
Status:  positive_review → closed 
comment:24 Changed 3 years ago by
Milestone:  sage9.2 → sage9.1 

New commits:
Added ramification_type().