Opened 3 years ago

Closed 3 years ago

#28751 closed enhancement (fixed)

enhance some calls to "while len"

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.0
Component: performance Keywords:
Cc: tscrim, jmantysalo, vklein Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo, Léo Brunswic
Report Upstream: N/A Work issues:
Branch: 3d0aed6 (Commits, GitHub, GitLab) Commit: 3d0aed69b74f580725a0504363613107407c77f4
Dependencies: Stopgaps:

Status badges

Description

by using faster tests

Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/28751
  • Commit set to fccbd81551b5ff8c69f7b9f6c35edbf8424e8c41
  • Status changed from new to needs_review

New commits:

fccbd81some care for "while len"

comment:2 Changed 3 years ago by git

  • Commit changed from fccbd81551b5ff8c69f7b9f6c35edbf8424e8c41 to 4c9b02ec29613c8e1a959a4420f205337fb94f96

Branch pushed to git repo; I updated commit sha1. New commits:

4c9b02eMerge branch 'u/chapoton/28751' in 9.0.b6

comment:3 Changed 3 years ago by git

  • Commit changed from 4c9b02ec29613c8e1a959a4420f205337fb94f96 to 3d0aed69b74f580725a0504363613107407c77f4

Branch pushed to git repo; I updated commit sha1. New commits:

3d0aed6fix

comment:4 Changed 3 years ago by chapoton

  • Cc tscrim added

bot is morally green, please review

comment:5 Changed 3 years ago by chapoton

  • Cc jmantysalo vklein added

review, someone, please ?

comment:6 Changed 3 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

Seems to be OK, but I got some other error and had to do make distclean. I'll be back...

comment:7 Changed 3 years ago by gh-LBrunswic

  • Reviewers changed from Jori Mäntysalo to Jori Mäntysalo, Léo Brunswic
  • Status changed from needs_review to positive_review

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/28751 to 3d0aed69b74f580725a0504363613107407c77f4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.