Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#2874 closed defect (fixed)

[with patch, positive review] add tests for type E root system, correct some misinformation in root_system.py, add Justin Walker credit

Reported by: bump Owned by: mhansen
Priority: minor Milestone: sage-3.0
Component: combinatorics Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This patch was written with Justin Walker, who originally coded the exceptional group root systems based on data from Bourbaki. The patch does 3 things.

(1) Replaces self.dim with self.rank in AmbientLattice_e and corrects some related misinformation in a comment in the file. (The a comment in the file formerly said that E6 had rank 5.)

(2) Adds tests. We checked the dimensions of the fundamental representations against what they are supposed to be (from another source), which is a convincing test that all the root data are correct.

(3) Adds a credit for Justin in the file. This was my idea since I know Justin worked hard on getting the exceptional groups coded but if it is controversial it can be taken down.

Attachments (1)

rootsystem.patch (6.6 KB) - added by bump 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by bump

comment:1 Changed 9 years ago by mhansen

  • Summary changed from add tests for type E root system, correct some misinformation in root_system.py, add Justin Walker credit to [with patch, positive review] add tests for type E root system, correct some misinformation in root_system.py, add Justin Walker credit

Yep, Justin should definitely get credit for the exceptional groups.

Looks good to me.

comment:2 Changed 9 years ago by mabshoff

Dan,

please post mercurial patches in the future. You need to use export instead of diff. That way you get properly credited in the log as author of the patch. Let me know if you have any more questions.

Cheers,

Michael

comment:3 Changed 9 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.alpha4

comment:4 Changed 8 years ago by nthiery

  • Cc sage-combinat added
Note: See TracTickets for help on using tickets.