Opened 3 years ago

Closed 2 years ago

#28728 closed defect (fixed)

gap fails its test suite

Reported by: jhpalmieri Owned by:
Priority: major Milestone: sage-9.1
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Matthias Koeppe Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: c02955f (Commits, GitHub, GitLab) Commit: c02955fd5ec86c05680bb847facb915143115a27
Dependencies: Stopgaps:

Status badges

Description

./sage -f -c gap fails with errors like

########> Diff in /Users/jpalmier/Desktop/Sage/sage_builds/TESTING/sage-9.0.be\
ta5/local/var/tmp/sage/build/gap-4.10.2.p1/src/tst/testinstall/strings.tst:44
# Input is:
x:="\0xFF";
# Expected output:
"\377"
# But found:
"ÿ"
########
########> Diff in /Users/jpalmier/Desktop/Sage/sage_builds/TESTING/sage-9.0.be\
ta5/local/var/tmp/sage/build/gap-4.10.2.p1/src/tst/testinstall/strings.tst:48
# Input is:
x:="A string with \0xFF Hex stuff \0x42 in it";
# Expected output:
"A string with \377 Hex stuff B in it"
# But found:
"A string with ÿ Hex stuff B in it"
########

Change History (12)

comment:1 Changed 2 years ago by embray

  • Milestone changed from sage-9.0 to sage-9.1

Ticket retargeted after milestone closed

comment:2 Changed 2 years ago by dimpase

is this on an unusual locale/architecture?

comment:3 Changed 2 years ago by jhpalmieri

This is with OS X 10.14.6. I don't think I have a locale set. I have this:

$ echo $LANG
en_US.UTF-8

comment:4 follow-up: Changed 2 years ago by dimpase

comment:5 in reply to: ↑ 4 Changed 2 years ago by jhpalmieri

Replying to dimpase:

check out if https://github.com/gap-system/homebrew-gap/issues/2#issuecomment-558382314 helps

export LC_CTYPE=en_US.UTF-8

That fixed it: the test suite passes.

In other news, the test suite appears fragile in other ways: I just ran tests on another OS X machine (10.15), and no files testinstall/* which come alphabetically after intarith.tst were tested: the testing stopped after intarith.tst. In particular, it didn't test the file strings.tst, which was problematic on the first machine.

comment:6 Changed 2 years ago by mkoeppe

I also get the same testsuite failure in ubuntu-xenial-standard (https://github.com/mkoeppe/sage/runs/503945069), ubuntu-bionic-standard, debian-buster-standard, etc.

comment:7 Changed 2 years ago by jhpalmieri

Can you set `LC_TYPE=en_US.UTF-8' and see if that helps?

comment:8 Changed 2 years ago by mkoeppe

  • Branch set to u/mkoeppe/gap_fails_its_test_suite

comment:9 Changed 2 years ago by mkoeppe

  • Commit set to c02955fd5ec86c05680bb847facb915143115a27

The fix on the branch helped on my macOS system. Tests for other platform run at https://github.com/mkoeppe/sage/actions/runs/55431568


New commits:

c02955fbuild/pkgs/gap/spkg-check: Set LC_CTYPE
Last edited 2 years ago by mkoeppe (previous) (diff)

comment:10 Changed 2 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Status changed from new to needs_review

comment:11 Changed 2 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Works for me. Thanks for creating the branch.

comment:12 Changed 2 years ago by vbraun

  • Branch changed from u/mkoeppe/gap_fails_its_test_suite to c02955fd5ec86c05680bb847facb915143115a27
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.