gap fails its test suite

[jhpalmieri]

./sage -f -c gap fails with errors like

########> Diff in /Users/jpalmier/Desktop/Sage/sage_builds/TESTING/sage-9.0.be\
ta5/local/var/tmp/sage/build/gap-4.10.2.p1/src/tst/testinstall/strings.tst:44
# Input is:
x:="\0xFF";
# Expected output:
"\377"
# But found:
"ÿ"
########
########> Diff in /Users/jpalmier/Desktop/Sage/sage_builds/TESTING/sage-9.0.be\
ta5/local/var/tmp/sage/build/gap-4.10.2.p1/src/tst/testinstall/strings.tst:48
# Input is:
x:="A string with \0xFF Hex stuff \0x42 in it";
# Expected output:
"A string with \377 Hex stuff B in it"
# But found:
"A string with ÿ Hex stuff B in it"
########

[embray]

Ticket retargeted after milestone closed

[dimpase]

is this on an unusual locale/architecture?

[jhpalmieri]

This is with OS X 10.14.6. I don't think I have a locale set. I have this:

$ echo $LANG
en_US.UTF-8

[dimpase]

check out if ​https://github.com/gap-system/homebrew-gap/issues/2#issuecomment-558382314 helps

export LC_CTYPE=en_US.UTF-8

[jhpalmieri]

Replying to dimpase:

check out if ​https://github.com/gap-system/homebrew-gap/issues/2#issuecomment-558382314 helps

export LC_CTYPE=en_US.UTF-8

That fixed it: the test suite passes.

In other news, the test suite appears fragile in other ways: I just ran tests on another OS X machine (10.15), and no files testinstall/* which come alphabetically after intarith.tst were tested: the testing stopped after intarith.tst. In particular, it didn't test the file strings.tst, which was problematic on the first machine.

[mkoeppe]

I also get the same testsuite failure in ubuntu-xenial-standard (​https://github.com/mkoeppe/sage/runs/503945069), ubuntu-bionic-standard, debian-buster-standard, etc.

[jhpalmieri]

Can you set `LC_TYPE=en_US.UTF-8' and see if that helps?

[mkoeppe]

The fix on the branch helped on my macOS system. Tests for other platform run at ​https://github.com/mkoeppe/sage/actions/runs/55431568

---

New commits:

​c02955f

build/pkgs/gap/spkg-check: Set LC_CTYPE

[jhpalmieri]

Works for me. Thanks for creating the branch.