Opened 3 years ago

Closed 3 years ago

#28725 closed defect (fixed)

fix lawrence_extension and lawrence_polytope for backend field

Reported by: gh-LaisRast Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: polytopes, lawerence
Cc: jipilab, gh-kliem Merged in:
Authors: Laith Rastanawi, Jonathan Kliem Reviewers: Laith Rastanawi, Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 50f9232 (Commits, GitHub, GitLab) Commit: 50f923224dcb6883555f8ea748e06e146a34a1c5
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-kliem)

The methods lawrence extension and lawrence_polytope of Polyhedron do not work when the backend is field. 

P = Polyhedron([[1,3], [3,4]], backend="field")
P.lawrence_extension([10,20])
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
TypeError: 'NoneType' object is not iterable

We fix this by properly initializing them with zero rays/lines instead of None.

Change History (5)

comment:1 Changed 3 years ago by gh-LaisRast

  • Description modified (diff)
  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 3 years ago by gh-kliem

  • Authors set to Laith Rastanawi, Jonathan Kliem
  • Branch set to public/28725
  • Commit set to 50f923224dcb6883555f8ea748e06e146a34a1c5
  • Description modified (diff)
  • Reviewers set to Laith Rastanawi, Jonathan Kliem
  • Status changed from new to needs_review

New commits:

​50f9232initialize Lawrence polytope with empty list of rays/lines instead of None

comment:3 Changed 3 years ago by gh-LaisRast

I think it is good to go. I will wait for the patchbot to finish so I can put it on "positive review".

comment:4 Changed 3 years ago by gh-kliem

  • Status changed from needs_review to positive_review

Bot is morally green.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from public/28725 to 50f923224dcb6883555f8ea748e06e146a34a1c5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.