Changes between Initial Version and Version 1 of Ticket #28716, comment 20


Ignore:
Timestamp:
11/19/19 15:19:52 (11 months ago)
Author:
gh-DeRhamSource
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28716, comment 20

    initial v1  
    11Replying to [comment:19 egourgoulhon]:
    2 > Replying to [comment:18 gh-DeRhamSource]:
    3 > > There is one thing I'm not sure about. Namely the line:
    4 > >
    5 > >
    6 > > {{{
    7 > >             mat = [[c[[i]] for c in comps] for i in fmodule.irange()]
    8 > >             aut.add_comp(basis)[:] = mat
    9 > >    this --> aut.add_comp(self)[:] = mat
    10 > >             fmodule.set_change_of_basis(basis, self, aut)
    11 > > }}}
    12 > > in `free_module_basis.py`.
    13 > >
    14 > > Shouldn't it be the identity matrix with respect to that basis? Or did I get something wrong?
    15 >
    162> The formula is correct: it should not be the identity matrix but the matrix of the change-of-basis automorphism, which has the same expression in both bases.
    173
    18 Yeah, you're absolutely right. I thought it through once again and come to the same conclusion now. Sorry!
     4Yeah, you're absolutely right. I thought it through once again and come to the same conclusion now. Furthermore, some tests on this did work properly. Sorry!
    195
    206So from my perspective, everything is fine. I'll give it a positive review.