Changes between Initial Version and Version 1 of Ticket #28716, comment 20
- Timestamp:
- 11/19/19 15:19:52 (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #28716, comment 20
initial v1 1 1 Replying to [comment:19 egourgoulhon]: 2 > Replying to [comment:18 gh-DeRhamSource]:3 > > There is one thing I'm not sure about. Namely the line:4 > >5 > >6 > > {{{7 > > mat = [[c[[i]] for c in comps] for i in fmodule.irange()]8 > > aut.add_comp(basis)[:] = mat9 > > this --> aut.add_comp(self)[:] = mat10 > > fmodule.set_change_of_basis(basis, self, aut)11 > > }}}12 > > in `free_module_basis.py`.13 > >14 > > Shouldn't it be the identity matrix with respect to that basis? Or did I get something wrong?15 >16 2 > The formula is correct: it should not be the identity matrix but the matrix of the change-of-basis automorphism, which has the same expression in both bases. 17 3 18 Yeah, you're absolutely right. I thought it through once again and come to the same conclusion now. Sorry!4 Yeah, you're absolutely right. I thought it through once again and come to the same conclusion now. Furthermore, some tests on this did work properly. Sorry! 19 5 20 6 So from my perspective, everything is fine. I'll give it a positive review.