#28700 closed defect (fixed)

Fixing missing optional flag in base_QQ.py

Reported by: jipilab Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: polytopes
Cc: jipilab, selia, slabbe Merged in:
Authors: Sophia Elia Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: 07372b5 (Commits, GitHub, GitLab) Commit: 07372b5b597a4d84e7a00e761a6faf2772d95541
Dependencies: Stopgaps:

Status badges

Description

This is to fix the failing doctests in

https://groups.google.com/forum/#!topic/sage-release/tNBwvPmOXiI

present in the file base_QQ.py, following-up #18957

Change History (7)

comment:1 Changed 18 months ago by selia

  • Branch set to public/28700
  • Commit set to 19b0b1e7b7dcb8a035365038e6657cde8a85176f

New commits:

19b0b1eadding optionals in base_QQ

comment:2 Changed 18 months ago by jipilab

  • Status changed from new to needs_review

Séb, could you check it on your computer? I can not reproduce the failure on my computer.

comment:3 Changed 18 months ago by jipilab

  • Authors set to Sophia Elia

comment:4 Changed 18 months ago by git

  • Commit changed from 19b0b1e7b7dcb8a035365038e6657cde8a85176f to 07372b5b597a4d84e7a00e761a6faf2772d95541

Branch pushed to git repo; I updated commit sha1. New commits:

07372b5Chaning the marking so both packages are necessary.

comment:5 Changed 18 months ago by tscrim

I fixed it so both packages are required. This used to fail (pynormaliz installed but not latte_int) but now is passes for me.

comment:6 Changed 18 months ago by slabbe

  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to positive_review

It fixes it.

comment:7 Changed 18 months ago by vbraun

  • Branch changed from public/28700 to 07372b5b597a4d84e7a00e761a6faf2772d95541
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.