Opened 9 years ago

Closed 9 years ago

Last modified 6 years ago

#2868 closed defect (fixed)

[with patch, positive review] Weight revision for fastcrystals

Reported by: bump Owned by: mhansen
Priority: minor Milestone: sage-3.0
Component: combinatorics Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by ltw)

This extends the revision of the patch in #2853

The previous patch reimplemented the weight function for vertices in crystals of letters and crystals of tableaux. The patch at hand does the corresponding reimplementation for fastcrystals. These are crystals whose definition is limited to types A2, B2, C2. They are isomorphic to crystals of tableaux but have better speed when the crystal is large, since the root operators are implemented by table lookup.

The revised weight function should be very fast since the weight is computed by adding a few numbers together.

This patch corrects the same defect for type A2 that the previous patch addressed.

The tests in the patch were written BEFORE the weight function was reimplemented, so I am confident that it is correct.

Attachments (2)

weight_fastcrystal.patch (3.0 KB) - added by bump 9 years ago.
2868.patch (3.0 KB) - added by mhansen 9 years ago.

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by bump

comment:1 Changed 9 years ago by bump

  • Owner changed from mhansen to bump
  • Status changed from new to assigned

comment:2 Changed 9 years ago by bump

  • Milestone set to sage-3.0

comment:3 Changed 9 years ago by bump

  • Owner changed from bump to mhansen
  • Status changed from assigned to new

comment:4 Changed 9 years ago by mabshoff

  • Summary changed from Weight revision for fastcrystals to [with patch, needs review] Weight revision for fastcrystals

Changed 9 years ago by mhansen

comment:5 Changed 9 years ago by mhansen

  • Status changed from new to assigned
  • Summary changed from [with patch, needs review] Weight revision for fastcrystals to [with patch, positive review] Weight revision for fastcrystals

I attached a new patch which removes a print statement and moves the tests down to the docstring of weight.

comment:6 Changed 9 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged 2868.patch in Sage 3.0.alpha4

comment:7 Changed 8 years ago by nthiery

  • Cc sage-combinat added

comment:8 Changed 6 years ago by ltw

  • Description modified (diff)
  • Report Upstream set to N/A
Note: See TracTickets for help on using tickets.