Opened 2 years ago

Closed 2 years ago

#28678 closed defect (fixed)

Bug in CombinatorialPolyhedron of empty Lattice polytope

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.0
Component: geometry Keywords: lattice polytopes, combinatorial polyhedron
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: 0a2e757 (Commits, GitHub, GitLab) Commit: 0a2e757fa979b18e64a498c8abbbe403265c49a4
Dependencies: Stopgaps:

Status badges

Description

Currently 

sage: CombinatorialPolyhedron(LatticePolytope([], lattice=ToricLattice(3)))

results in a TypeError, as an empty list of facets is not detected as empty polyhedron.

We fix this: 

sage: CombinatorialPolyhedron(LatticePolytope([], lattice=ToricLattice(3)))
A -1-dimensional combinatorial polyhedron with 0 facets

Change History (3)

comment:1 Changed 2 years ago by gh-kliem

  • Branch set to u/gh-kliem/fixemptylatticepolytope
  • Commit set to 0a2e757fa979b18e64a498c8abbbe403265c49a4
  • Status changed from new to needs_review

New commits:

​0a2e757fix CombinatorialPolyhedron of empty lattice polytope

comment:2 Changed 2 years ago by jipilab

  • Reviewers set to Jean-Philippe Labbé
  • Status changed from needs_review to positive_review

Ok, sounds good.

comment:3 Changed 2 years ago by vbraun

  • Branch changed from u/gh-kliem/fixemptylatticepolytope to 0a2e757fa979b18e64a498c8abbbe403265c49a4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.