Opened 2 years ago

Closed 22 months ago

Last modified 16 months ago

#28676 closed defect (fixed)

Pass --with-python=sage-python23 to Singular configure

Reported by: slelievre Owned by:
Priority: critical Milestone: sage-9.0
Component: build Keywords: Singular
Cc: isuruf, slelievre, dimpase Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 68327e9 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

Either singular should depend on the python package or --without-python should be passed to configure. Otherwise the configure script may find some unexpected python version.

See sage-release discussion:

Change History (6)

comment:1 Changed 22 months ago by mkoeppe

  • Branch set to u/mkoeppe/singular-configure-python

comment:2 Changed 22 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc dimpase added
  • Commit set to 68327e976c9bc65f60debd1a7022ccca9f4fb2a1
  • Description modified (diff)
  • Priority changed from major to critical
  • Status changed from new to needs_review
  • Summary changed from Clarify Singular dependence on Python to Pass --with-python=sage-python23 to Singular configure

This is a problem for anyone who has a python2.7 binary somewhere in PATH, for example in /usr/local/bin, coming from homebrew.

With the simple patch on this ticket, in a Python 3 build of Sage, this now gives:

[singular-4.1.1p2.p0] checking for --with-python... sage-python23
[singular-4.1.1p2.p0] checking whether sage-python23 version >= 2.4... yes
[singular-4.1.1p2.p0] checking whether sage-python23 version >= 3... too recent, skipping python interface!

New commits:

68327e928676: Pass --with-python=sage-python23 to Singular configure

comment:3 Changed 22 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

Looks good to me. As far as I understand, it has no effect on sagelib, only on possible use of Singular's python interface outside of sagelib.

comment:4 Changed 22 months ago by fbissey

Yes, there are no effects on sagelib. And as I remember py3 is not supported, so this interface will probably just die since upstream doesn't seem to be interested in porting it to a more recent python. Not that we should care.

comment:5 Changed 22 months ago by vbraun

  • Branch changed from u/mkoeppe/singular-configure-python to 68327e976c9bc65f60debd1a7022ccca9f4fb2a1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 16 months ago by mkoeppe

  • Commit 68327e976c9bc65f60debd1a7022ccca9f4fb2a1 deleted

Follow up in #25993 - where we change it to --without-python

Note: See TracTickets for help on using tickets.